Bug 72266 - Add support for the caretBrowsingEnabled preference in WebKit2
Summary: Add support for the caretBrowsingEnabled preference in WebKit2
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks: 72267
  Show dependency tree / graph
 
Reported: 2011-11-14 06:20 PST by Mario Sanchez Prada
Modified: 2011-11-14 09:05 PST (History)
5 users (show)

See Also:

Attachments
Patch proposal (5.10 KB, patch)
2011-11-14 06:32 PST, Mario Sanchez Prada 		no flags Details | Formatted Diff | Diff
Patch proposal (6.72 KB, patch)
2011-11-14 07:19 PST, Mario Sanchez Prada 		cfleizach: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mario Sanchez Prada 2011-11-14 06:20:29 PST 
We need to expose this preference in WebKit2 C API so ports that need to interact with it (e.g. the GTK port) can easily do it.
Comment 1 Mario Sanchez Prada 2011-11-14 06:32:41 PST 
Created attachment 114936 [details]
Patch proposal
Comment 2 Carlos Garcia Campos 2011-11-14 06:38:57 PST 
Comment on attachment 114936 [details]
Patch proposal

LGTM
Comment 3 Mario Sanchez Prada 2011-11-14 07:19:24 PST 
Created attachment 114944 [details]
Patch proposal

Now featuring the missing symbol that caused the mac build to fail!
Comment 4 chris fleizach 2011-11-14 08:52:20 PST 
Comment on attachment 114944 [details]
Patch proposal

r=me
Comment 5 Mario Sanchez Prada 2011-11-14 09:05:45 PST 
Committed r100153: <http://trac.webkit.org/changeset/100153>