Bug 72045 - Remove ability to call HTMLCollections in V8 bindings as well.
Summary: Remove ability to call HTMLCollections in V8 bindings as well.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore JavaScript (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Andreas Kling
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-11-10 12:39 PST by Andreas Kling
Modified: 2011-11-11 06:38 PST (History)
8 users (show)

See Also:

Attachments
Patch for EWS (5.24 KB, patch)
2011-11-10 12:44 PST, Andreas Kling 		no flags Details | Formatted Diff | Diff
Proposed patch (9.19 KB, patch)
2011-11-11 05:14 PST, Andreas Kling 		andersca: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Andreas Kling 2011-11-10 12:39:24 PST 
Bug 67579 removed the ability to call HTMLCollections (excluding HTMLAllCollection) via the JSC bindings.

Let's try the same for the V8 bindings. Patch coming..
Comment 1 Andreas Kling 2011-11-10 12:44:11 PST 
Created attachment 114547 [details]
Patch for EWS
Comment 2 Darin Adler 2011-11-10 12:44:51 PST 
You don’t need to submit a patch for review to submit it for EWS any more. Do you?
Comment 3 Andreas Kling 2011-11-10 12:45:58 PST 
(In reply to comment #2)
> You don’t need to submit a patch for review to submit it for EWS any more. Do you?

Oh, I didn't realize. Sorry about that.
Comment 4 Adam Barth 2011-11-10 14:30:51 PST 
Comment on attachment 114547 [details]
Patch for EWS

View in context: https://bugs.webkit.org/attachment.cgi?id=114547&action=review

> Source/WebCore/ChangeLog:17
> +            Remove the V8CustomCall attribute as it's no longer needed.

Are there tests that show that these interfaces are no longer callable?  (Other than that, this looks great.)
Comment 5 Andreas Kling 2011-11-11 05:14:06 PST 
Created attachment 114679 [details]
Proposed patch
Comment 6 Andreas Kling 2011-11-11 06:38:15 PST 
Committed r99958: <http://trac.webkit.org/changeset/99958>