Bug 67579 - Experiment with removing ability to call a collection (except document.all)
: Experiment with removing ability to call a collection (except document.all)
Status: RESOLVED FIXED
Product: WebKit
Classification: Unclassified
Component: WebCore JavaScript
: 528+ (Nightly build)
: All All
: P2 Normal
Assigned To: Sam Weinig
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2011-09-04 14:27 PDT by Sam Weinig
Modified: 2012-01-30 16:07 PST (History)
7 users (show)

See Also:


Attachments
Patch (6.06 KB, patch)
2011-09-04 14:28 PDT, Sam Weinig
no flags Details | Formatted Diff | Diff
Patch (13.49 KB, patch)
2011-09-14 22:19 PDT, Sam Weinig
no flags Details | Formatted Diff | Diff
Patch (14.66 KB, patch)
2011-09-15 09:26 PDT, Sam Weinig
andersca: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Sam Weinig 2011-09-04 14:27:36 PDT
public-script-coord would like us to experiment with removing the ability to call collections (with the exception of document.all) and see what breaks.
Comment 1 Sam Weinig 2011-09-04 14:28:56 PDT
Created attachment 106295 [details]
Patch
Comment 2 WebKit Review Bot 2011-09-04 14:34:24 PDT
Comment on attachment 106295 [details]
Patch

Attachment 106295 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/9590451
Comment 3 Sam Weinig 2011-09-04 14:43:43 PDT
There are some tests that would need updating/removal if we do this.
Comment 4 WebKit Review Bot 2011-09-04 15:30:07 PDT
Comment on attachment 106295 [details]
Patch

Attachment 106295 [details] did not pass cr-mac-ews (chromium):
Output: http://queues.webkit.org/results/9593299
Comment 5 WebKit Review Bot 2011-09-04 15:49:15 PDT
Comment on attachment 106295 [details]
Patch

Attachment 106295 [details] did not pass cr-mac-ews (chromium):
Output: http://queues.webkit.org/results/9593303
Comment 6 Sam Weinig 2011-09-14 22:19:40 PDT
Created attachment 107458 [details]
Patch
Comment 7 Sam Weinig 2011-09-14 22:21:54 PDT
Let's try this experiment.  Patch ho!
Comment 8 WebKit Review Bot 2011-09-14 22:58:29 PDT
Comment on attachment 107458 [details]
Patch

Attachment 107458 [details] did not pass cr-mac-ews (chromium):
Output: http://queues.webkit.org/results/9655860
Comment 9 WebKit Review Bot 2011-09-15 05:29:46 PDT
Comment on attachment 107458 [details]
Patch

Attachment 107458 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/9689030
Comment 10 Sam Weinig 2011-09-15 09:26:47 PDT
Created attachment 107504 [details]
Patch
Comment 11 Anders Carlsson 2011-09-15 11:15:17 PDT
Comment on attachment 107504 [details]
Patch

Please add some more background info to the ChangeLog, looks great otherwise!
Comment 12 Sam Weinig 2011-09-15 11:26:46 PDT
Committed r95203: <http://trac.webkit.org/changeset/95203>
Comment 13 mitz@webkit.org 2011-10-17 22:02:48 PDT
(In reply to comment #12)
> Committed r95203: <http://trac.webkit.org/changeset/95203>

This broke the iTunes Store. See bug 70303.
Comment 14 Adam Barth 2012-01-30 16:07:51 PST
We've received one complaint about this change:
http://code.google.com/p/chromium/issues/detail?id=110985