Test for drawImage(video) with different composite modes
Created attachment 114424 [details] Patch
Attachment 114424 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'LayoutTests/fast..." exit_code: 1 Last 3072 characters of output: s not exist. svg/as-image/animated-svg-as-image-same-image.html [test/expectations] [2] LayoutTests/platform/chromium/test_expectations.txt:3896: Path does not exist. svg/as-image/animated-svg-as-image-same-image.html [test/expectations] [2] LayoutTests/platform/chromium/test_expectations.txt:3897: Path does not exist. svg/zoom/page/zoom-coords-viewattr-01-b.svg [test/expectations] [2] LayoutTests/platform/chromium/test_expectations.txt:3898: Path does not exist. fast/backgrounds/svg-as-mask.html [test/expectations] [2] LayoutTests/platform/chromium/test_expectations.txt:3899: Path does not exist. fast/backgrounds/size/contain-and-cover.html [test/expectations] [2] LayoutTests/platform/chromium/test_expectations.txt:3900: Path does not exist. svg/as-background-image/svg-as-background-5.html [test/expectations] [2] LayoutTests/platform/chromium/test_expectations.txt:3901: Path does not exist. svg/custom/embedding-external-svgs.xhtml [test/expectations] [2] LayoutTests/platform/chromium/test_expectations.txt:3903: Path does not exist. svg/as-border-image/svg-as-border-image.html [test/expectations] [2] LayoutTests/platform/chromium/test_expectations.txt:3904: Path does not exist. svg/zoom/page/zoom-img-preserveAspectRatio-support-1.html [test/expectations] [2] LayoutTests/platform/chromium/test_expectations.txt:3905: Path does not exist. svg/as-background-image/svg-as-background-1.html [test/expectations] [2] LayoutTests/platform/chromium/test_expectations.txt:3906: Path does not exist. svg/as-background-image/svg-as-background-3.html [test/expectations] [2] LayoutTests/platform/chromium/test_expectations.txt:3908: Path does not exist. svg/zoom/page/zoom-svg-as-relative-image.html [test/expectations] [2] LayoutTests/platform/chromium/test_expectations.txt:3909: Path does not exist. svg/zoom/page/relative-sized-document-scrollbars.svg [test/expectations] [2] LayoutTests/platform/chromium/test_expectations.txt:3911: Path does not exist. storage/indexeddb/key-type-array.html [test/expectations] [2] LayoutTests/platform/chromium/test_expectations.txt:3913: Path does not exist. fast/js/array-functions-non-arrays.html [test/expectations] [2] LayoutTests/platform/chromium/test_expectations.txt:3914: Path does not exist. fast/js/eval-cross-window.html [test/expectations] [2] LayoutTests/platform/chromium/test_expectations.txt:3915: Path does not exist. fast/js/regexp-caching.html [test/expectations] [2] LayoutTests/platform/chromium/test_expectations.txt:3916: Path does not exist. fast/js/toString-overrides.html [test/expectations] [2] LayoutTests/platform/chromium/test_expectations.txt:3917: Path does not exist. fast/js/toString-recursion.html [test/expectations] [2] LayoutTests/platform/chromium/test_expectations.txt:3918: Path does not exist. http/tests/security/xss-eval.html [test/expectations] [2] LayoutTests/platform/chromium/test_expectations.txt:3920: Path does not exist. fast/dom/rtl-scroll-to-leftmost-and-resize.html [test/expectations] [2] Total errors found: 2166 in 8 files If any of these errors are false positives, please file a bug against check-webkit-style.
Style error looks unrelated to this change.
Comment on attachment 114424 [details] Patch Looks great. The style error looks like some problem on the bot. r=me
Comment on attachment 114424 [details] Patch Rejecting attachment 114424 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 Last 500 characters of output: outTests/platform/gtk/Skipped Hunk #1 FAILED at 1598. 1 out of 1 hunk FAILED -- saving rejects to file LayoutTests/platform/gtk/Skipped.rej patching file LayoutTests/platform/mac/Skipped patching file LayoutTests/platform/qt/Skipped Hunk #1 succeeded at 2502 (offset -2 lines). patching file LayoutTests/platform/win/Skipped Hunk #1 succeeded at 1449 (offset 3 lines). Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--reviewer', u'Kenneth Russell', u'--..." exit_code: 1 Full output: http://queues.webkit.org/results/10448498
Comment on attachment 114424 [details] Patch Ben is not a committer. Since this one doesn't apply, he'll need to upload a new patch.
(In reply to comment #6) > (From update of attachment 114424 [details]) > Ben is not a committer. Since this one doesn't apply, he'll need to upload a new patch. Quick update: the test started failing very soon after I uploaded the initial patch, due to some change in video handling. The problem made Chromium (not Chrome) and Safari kind of incompatible in that they both require different ordering of html 5 video sources. The Chromium bug is here: http://crbug.com/104577. If its resolved in the near term I'll update the patch and reapply.
Alternate approach mentioned in Comment 07 (Chrome bug - it shows that it was fixed downstream in Webkit), landed in bug 79934. Is something else required here or this can be marked as "RESOLVED WONTFIX"? Thanks!