Bug 79934 - Continue the search for playable mime types among <source> children of <video> even when using data: URLs
Summary: Continue the search for playable mime types among <source> children of <video...
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ami Fischman
Depends on:
Reported: 2012-02-29 12:50 PST by Ami Fischman
Modified: 2013-02-21 16:29 PST (History)
4 users (show)

See Also:

Patch (28.67 KB, patch)
2012-02-29 12:52 PST, Ami Fischman
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Ami Fischman 2012-02-29 12:50:49 PST
This is migrated from http://crbug.com/104577

When <source>'s specify their mime-type using a type attribute, fallback works correctly (an unsupported type causes an error to fire and the next <source> is tried).  When mime-type is instead specified inside a data: url in the src attribute, multiple errors are fired (according to --webcore-log-channels=Media) and the second <source> is never considered.
Comment 1 Ami Fischman 2012-02-29 12:52:09 PST
Created attachment 129494 [details]
Comment 2 Eric Carlson 2012-02-29 13:04:34 PST
Comment on attachment 129494 [details]

Nice fix and test, thanks!
Comment 3 WebKit Review Bot 2012-02-29 19:38:18 PST
Comment on attachment 129494 [details]

Clearing flags on attachment: 129494

Committed r109298: <http://trac.webkit.org/changeset/109298>
Comment 4 WebKit Review Bot 2012-02-29 19:38:22 PST
All reviewed patches have been landed.  Closing bug.
Comment 5 Jer Noble 2013-02-21 16:09:09 PST
There's something wonky about the structure of the mp4 test files. The atom lengths of the movie add up to greater than the decoded length of the data.  This is causing the test to fail on some Mac platforms as the media engines reject the file.
Comment 6 Jer Noble 2013-02-21 16:29:27 PST
My apologies; I messed up a copy-paste operation.