Bug 71900 – CSS Exclusions: parse the wrap-margin and wrap-padding properties

• Status: RESOLVED
• Resolution: FIXED
• Component: CSS

[Alexandru Chiculita]

Add parsing support for wrap-margin and wrap-padding of the CSS Exclusions spec.

http://dev.w3.org/csswg/css3-exclusions/#wrap-margin-property
http://dev.w3.org/csswg/css3-exclusions/#wrap-padding-property

[Radar WebKit Bug Importer]

<rdar://problem/10419706>

[Mihnea Ovidenie]

Created attachment 114892 [details]
Patch

[WebKit Review Bot]

Comment on attachment 114892 [details]
Patch

Attachment 114892 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/10437137

New failing tests:
svg/css/getComputedStyle-basic.xhtml
fast/css/getComputedStyle/computed-style.html
fast/css/getComputedStyle/computed-style-without-renderer.html

[Mihnea Ovidenie]

Created attachment 114900 [details]
Patch 2

Now including the missed tests.

[WebKit Review Bot]

Comment on attachment 114900 [details]
Patch 2

Attachment 114900 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/10472225

New failing tests:
svg/css/getComputedStyle-basic.xhtml
fast/css/getComputedStyle/computed-style.html
fast/css/getComputedStyle/computed-style-without-renderer.html

[Mihnea Ovidenie]

(In reply to comment #5)
> (From update of attachment 114900 [details])
> Attachment 114900 [details] did not pass chromium-ews (chromium-xvfb):
> Output: http://queues.webkit.org/results/10472225
> 
> New failing tests:
> svg/css/getComputedStyle-basic.xhtml
> fast/css/getComputedStyle/computed-style.html
> fast/css/getComputedStyle/computed-style-without-renderer.html

Not sure why it failed this time since i have modified the expected results.

[Adam Barth]

> Not sure why it failed this time since i have modified the expected results.

Perhaps different ports have different expectations for these tests based on which features they have enabled?

[Mihnea Ovidenie]

(In reply to comment #7)
> > Not sure why it failed this time since i have modified the expected results.
> 
> Perhaps different ports have different expectations for these tests based on which features they have enabled?

Actually, the failure comes from the chromium bot. Is there a way to see why a certain test has failed and the diff associated with the failure?

[Mihnea Ovidenie]

Created attachment 115103 [details]
Patch 3

Same patch with expected results for chromium-win.

[WebKit Review Bot]

Comment on attachment 115103 [details]
Patch 3

Rejecting attachment 115103 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2

Last 500 characters of output:
n/master/.rev_map.268f45cc-cd09-0410-ab3c-d52691b4dbfc
First, rewinding head to replay your work on top of it...
Fast-forwarded master to refs/remotes/origin/master.
Updating chromium port dependencies using gclient...

________ running '/usr/bin/python tools/clang/scripts/update.py --mac-only' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium'

________ running '/usr/bin/python gyp_webkit' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium'
Updating webkit projects from gyp files...

Full output: http://queues.webkit.org/results/10340123

[Adam Barth]

1 out of 3 hunks FAILED -- saving rejects to file Source/WebCore/rendering/style/StyleRareNonInheritedData.cpp.rej

[Mihnea Ovidenie]

Created attachment 115553 [details]
Patch for landing

[WebKit Review Bot]

Comment on attachment 115553 [details]
Patch for landing

Clearing flags on attachment: 115553

Committed r100604: <http://trac.webkit.org/changeset/100604>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.