Bug 71895 - MediaStream API: Extending MediaStreamRegistry
Summary: MediaStream API: Extending MediaStreamRegistry
Status: RESOLVED INVALID
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Tommy Widenflycht
URL:
Keywords:
Depends on:
Blocks: 56459
  Show dependency tree / graph
 
Reported: 2011-11-09 06:00 PST by Tommy Widenflycht
Modified: 2011-11-09 08:47 PST (History)
4 users (show)

See Also:

Attachments
Patch (4.49 KB, patch)
2011-11-09 06:12 PST, Tommy Widenflycht 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tommy Widenflycht 2011-11-09 06:00:45 PST 
Extending MediaStreamRegistry so that MediaStreamDescriptors can be looked up by label as well as any public blob URLs.
Comment 1 Tommy Widenflycht 2011-11-09 06:12:28 PST 
Created attachment 114258 [details]
Patch
Comment 2 Adam Bergkvist 2011-11-09 07:40:24 PST 
How is this intended to be used? The MediaStream label is not guaranteed to be unique to a particular MediaStream instance.
Comment 3 Adam Barth 2011-11-09 08:30:23 PST 
Comment on attachment 114258 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=114258&action=review

> Source/WebCore/ChangeLog:8
> +        MediaStream API: Extending MediaStreamRegistry
> +        https://bugs.webkit.org/show_bug.cgi?id=71895
> +
> +        Reviewed by NOBODY (OOPS!).
> +
> +        Tests for the Media Stream API will be provided by the bug 56587, pending enough landed code.

Can you add more of an explanation to the ChangeLog?  The ChangeLog should explain why we're making this change.  I don't really understand what this change achieves (mostly due to my ignorance).
Comment 4 Tommy Widenflycht 2011-11-09 08:45:48 PST 
(In reply to comment #2)
> How is this intended to be used? The MediaStream label is not guaranteed to be unique to a particular MediaStream instance.

Right, I forgot the bounced MediaStream scenario...
Comment 5 Tommy Widenflycht 2011-11-09 08:47:54 PST 
This was to slightly simplify the embedder code but Adam Bergkvist reminded me why this wont work.

(In reply to comment #3)
> (From update of attachment 114258 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=114258&action=review
> 
> > Source/WebCore/ChangeLog:8
> > +        MediaStream API: Extending MediaStreamRegistry
> > +        https://bugs.webkit.org/show_bug.cgi?id=71895
> > +
> > +        Reviewed by NOBODY (OOPS!).
> > +
> > +        Tests for the Media Stream API will be provided by the bug 56587, pending enough landed code.
> 
> Can you add more of an explanation to the ChangeLog?  The ChangeLog should explain why we're making this change.  I don't really understand what this change achieves (mostly due to my ignorance).