If a class has [Constructor] or [CustomConstructor], then [CanBeConstructed] is not necessary. We can just remove [CanBeConstructed] from the classes that already have [Constructor] or [CustomConstructor].
Created attachment 114184 [details] Patch
Comment on attachment 114184 [details] Patch Attachment 114184 [details] did not pass efl-ews (efl): Output: http://queues.webkit.org/results/10378237
Comment on attachment 114184 [details] Patch Attachment 114184 [details] did not pass qt-ews (qt): Output: http://queues.webkit.org/results/10375295
Comment on attachment 114184 [details] Patch Attachment 114184 [details] did not pass gtk-ews (gtk): Output: http://queues.webkit.org/results/10369292
Comment on attachment 114184 [details] Patch Attachment 114184 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/10375347 New failing tests: animations/animation-matrix-negative-scale-unmatrix.html http/tests/eventsource/eventsource-bad-mime-type.html fast/eventsource/eventsource-constructor.html http/tests/eventsource/eventsource-reconnect.html http/tests/eventsource/non-existent-eventsource-status-error-iframe-crash.html fast/events/dispatchEvent-crash.html http/tests/eventsource/eventsource-parse-event-stream.html http/tests/eventsource/eventsource-status-code-states.html fast/dom/dom-constructors.html fast/dom/global-constructors.html http/tests/inspector/network-preflight-options.html fast/js/instanceof-XMLHttpRequest.html fast/dom/call-a-constructor-as-a-function.html fast/eventsource/eventsource-attribute-listeners.html http/tests/eventsource/existent-eventsource-status-error-iframe-crash.html fast/dom/Window/custom-constructors.html http/tests/eventsource/eventsource-reconnect-during-navigate-crash.html http/tests/eventsource/eventsource-content-type-charset.html animations/combo-transform-translate+scale.html
Created attachment 114302 [details] Patch
Comment on attachment 114302 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=114302&action=review > Source/WebCore/bindings/scripts/CodeGeneratorV8.pm:2382 > - if ($dataNode->extendedAttributes->{"CanBeConstructed"} || $dataNode->extendedAttributes->{"CustomConstructor"} || $dataNode->extendedAttributes->{"V8CustomConstructor"} || $dataNode->extendedAttributes->{"Constructer"}) { > + if ($dataNode->extendedAttributes->{"CanBeConstructed"} || $dataNode->extendedAttributes->{"CustomConstructor"} || $dataNode->extendedAttributes->{"V8CustomConstructor"} || $dataNode->extendedAttributes->{"Constructor"}) { Sorry I missed in the last patch!
Comment on attachment 114302 [details] Patch Clearing flags on attachment: 114302 Committed r99732: <http://trac.webkit.org/changeset/99732>
All reviewed patches have been landed. Closing bug.