Bug 71832 – [meta] Remove [CanBeConstructed] IDL

• Status: RESOLVED
• Resolution: FIXED
• Component: DOM

[Kentaro Hara]

Now we have [Constructor] IDL for both JSC and V8. We can remove [CanBeConstructed] IDL, which is not a speced Web IDL.

- If a class has both [CanBeConstructed] and [Constructor] IDL, we can just remove [CanBeConstructed] IDL from the class.
- If a class has [CanBeConstructed] IDL but does not have [Constructor] IDL, we can add [Constructor] IDL and remove [CanBeConstructed] IDL.
- We can remove V8Proxy::constructDOMObject and V8Proxy::constructDOMObjectWithScriptExecutionContext.

[Kentaro Hara]

Created attachment 114165 [details]
WIP patch

[Kentaro Hara]

I uploaded a WIP patch. I am planning to land it in the following steps:

[1] Just remove [CanBeConstructed] IDL from the following IDLs.
Event.idl, Worker.idl, ErrorEvent.idl, CustomEvent.idl, EventSource.idl, WebKitCSSMatrix.idl, WebKitPoint.idl, OverFlowEvent.idl, AudioContext.idl, DOMFormData.idl, PopStateEvent.idl, MessageEvent.idl, XMLHttpRequest.idl, DataView.idl, ProgressEvent.idl, WebSocket.idl, HashChangeEvent.idl, XSLTProcessor.idl, TextTrackCue.idl, PeerConnection.idl, Int16Array.idl, Float64Array.idl, WebKitAnimationEvent.idl, WebKitMutationObserver.idl, PageTransitionEvent.idl, BeforeLoadEvent.idl, MessageChannel.idl, WebKitTransitionEvent.idl, CloseEvent.idl, SharedWorker.idl, TrackEvent.idl, Int32Array.idl, ArrayBuffer.idl, Float32Array.idl, Int8Array.idl, Uint32Array.idl, Uint16Array.idl, Uint8Array.idl

[2] Replaced [CanBeConstructed] IDL with [Constructor] IDL in the following IDLs.
DOMParser.idl, WebKitFlags.idl, XMLSerializer.idl, XPathEvaluator.idl, FileReader.idl
FileReaderSync.idl, WebKitBlobBuilder.idl

[3] Remove [CanBeConstructed] related code from CodeGeneratorJS.pm

[4] Remove [CanBeConstructed] related code from CodeGeneratorV8.pm

[Adam Barth]

> I am planning to land it in the following steps:

Those sound like good steps.

[Kentaro Hara]

All patches were landed.