Bug 71596 – WebKitMutationObserver.observe should raise a DOMException if passed invalid arguments

• Status: RESOLVED
• Resolution: FIXED
• Component: DOM

[Adam Klein]

For example, a null Node currently leads to a crash. We should also validate the options argument.

[Adam Klein]

Created attachment 113923 [details]
Patch

[Ryosuke Niwa]

Comment on attachment 113923 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=113923&action=review

> Source/WebCore/ChangeLog:9
> +        exception:

Could you fit "exception:" on the previous line specially because the bug title is already longer than the previous line?

> Source/WebCore/dom/WebKitMutationObserver.cpp:78
> +        ec = NOT_FOUND_ERR;
> +        return;
> +    }
> +
> +    if (!validateOptions(options)) {
> +        ec = SYNTAX_ERR;

We should really agree which exceptions are thrown for each one of cases we're throwing on public-webapps.

> Source/WebCore/dom/WebKitMutationObserver.h:51
> +typedef int ExceptionCode;
> +

Please include ExceptionCode.h instead. r=me provided this change.

[Adam Klein]

Comment on attachment 113923 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=113923&action=review

>> Source/WebCore/dom/WebKitMutationObserver.cpp:78
>> +        ec = SYNTAX_ERR;
> 
> We should really agree which exceptions are thrown for each one of cases we're throwing on public-webapps.

Yeah, I'll ask Anne for his opinion on these (right now the spec says these throw an "Error", which isn't right).  NOT_FOUND_ERR was picked to be consistent with other Node-typed arguments, but SYNTAX_ERR may well be wrong here; added a FIXME.

>> Source/WebCore/dom/WebKitMutationObserver.h:51
>> +
> 
> Please include ExceptionCode.h instead. r=me provided this change.

Done. I'll send you a separate patch to get rid of the rest of these typedefs in WebCore (the typedef is about as common as the include).

[Adam Klein]

Created attachment 114094 [details]
Patch for landing

[WebKit Review Bot]

Comment on attachment 114094 [details]
Patch for landing

Rejecting attachment 114094 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2

Last 500 characters of output:
n/master/.rev_map.268f45cc-cd09-0410-ab3c-d52691b4dbfc
First, rewinding head to replay your work on top of it...
Fast-forwarded master to refs/remotes/origin/master.
Updating chromium port dependencies using gclient...

________ running '/usr/bin/python tools/clang/scripts/update.py --mac-only' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium'

________ running '/usr/bin/python gyp_webkit' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium'
Updating webkit projects from gyp files...

Full output: http://queues.webkit.org/results/10375151

[Adam Klein]

Created attachment 114131 [details]
Patch for landing

[WebKit Review Bot]

Comment on attachment 114131 [details]
Patch for landing

Clearing flags on attachment: 114131

Committed r99611: <http://trac.webkit.org/changeset/99611>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.