Bug 71485 - [Chromium] Rename WebView::scalePage to WebView::setPageScaleFactor to match WebCore
Summary: [Chromium] Rename WebView::scalePage to WebView::setPageScaleFactor to match ...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit API (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Fady Samuel
URL:
Keywords:
Depends on:
Blocks: 70559 71622
  Show dependency tree / graph
 
Reported: 2011-11-03 10:41 PDT by Fady Samuel
Modified: 2011-11-07 10:25 PST (History)
3 users (show)

See Also:

Attachments
Patch (5.94 KB, patch)
2011-11-05 19:48 PDT, Fady Samuel 		no flags Details | Formatted Diff | Diff
Patch (6.23 KB, patch)
2011-11-07 09:59 PST, Fady Samuel 		no flags Details | Formatted Diff | Diff
Patch (6.23 KB, patch)
2011-11-07 10:12 PST, Fady Samuel 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Fady Samuel 2011-11-03 10:41:18 PDT 
Need to first get rid of the hack in Chromium renderer to set page scale factor because it's currently broken after a refactoring. Will post Chromium side + WebKit side changes shortly. The Chromium side change needs to land first.
Comment 1 Fady Samuel 2011-11-05 19:48:11 PDT 
Created attachment 113776 [details]
Patch
Comment 2 WebKit Review Bot 2011-11-05 19:52:49 PDT 
Please wait for approval from fishd@chromium.org before submitting because this patch contains changes to the Chromium public API.
Comment 3 Darin Fisher (:fishd, Google) 2011-11-07 09:22:55 PST 
Comment on attachment 113776 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=113776&action=review

> Source/WebKit/chromium/public/WebView.h:220
> +    virtual void setPageScaleFactor(float scaleFactor, WebPoint origin) = 0;

nit: while you are at it, the WebPoint parameter should probably be passed as "const WebPoint&"
Comment 4 Fady Samuel 2011-11-07 09:59:04 PST 
Created attachment 113885 [details]
Patch
Comment 5 Fady Samuel 2011-11-07 10:12:19 PST 
Created attachment 113887 [details]
Patch
Comment 6 Fady Samuel 2011-11-07 10:24:56 PST 
Comment on attachment 113887 [details]
Patch

Clearing flags on attachment: 113887

Committed r99440: <http://trac.webkit.org/changeset/99440>
Comment 7 Fady Samuel 2011-11-07 10:25:02 PST 
All reviewed patches have been landed.  Closing bug.