WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
71423
Remove all releaseRef implementations except for RetainPtr
https://bugs.webkit.org/show_bug.cgi?id=71423
Summary
Remove all releaseRef implementations except for RetainPtr
Darin Adler
Reported
2011-11-02 17:13:43 PDT
Last step in renaming releaseRef to leakRef.
Attachments
Patch
(4.41 KB, patch)
2011-11-10 08:26 PST
,
Darin Adler
no flags
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Darin Adler
Comment 1
2011-11-10 08:26:52 PST
Created
attachment 114508
[details]
Patch
Julien Chaffraix
Comment 2
2011-11-10 12:05:56 PST
Comment on
attachment 114508
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=114508&action=review
> Source/JavaScriptCore/API/JSRetainPtr.h:-75 > - T releaseRef() { return leakRef(); }
I guess you have discussed this API breakage.
Darin Adler
Comment 3
2011-11-10 12:07:50 PST
(In reply to
comment #2
)
> I guess you have discussed this API breakage.
Is JSRetainPtr API? On what platforms?
Julien Chaffraix
Comment 4
2011-11-10 12:13:13 PST
(In reply to
comment #3
)
> (In reply to
comment #2
) > > I guess you have discussed this API breakage. > > Is JSRetainPtr API? On what platforms?
I thought it was exposed to the JSC API but it is actually not exposed.
WebKit Review Bot
Comment 5
2011-11-11 14:52:15 PST
Comment on
attachment 114508
[details]
Patch Clearing flags on attachment: 114508 Committed
r100030
: <
http://trac.webkit.org/changeset/100030
>
WebKit Review Bot
Comment 6
2011-11-11 14:52:19 PST
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug