Bug 71423 - Remove all releaseRef implementations except for RetainPtr
Summary: Remove all releaseRef implementations except for RetainPtr
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Template Framework (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Darin Adler
URL:
Keywords:
Depends on:
Blocks: 41374
  Show dependency tree / graph
 
Reported: 2011-11-02 17:13 PDT by Darin Adler
Modified: 2011-11-11 14:52 PST (History)
2 users (show)

See Also:

Attachments
Patch (4.41 KB, patch)
2011-11-10 08:26 PST, Darin Adler 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Darin Adler 2011-11-02 17:13:43 PDT 
Last step in renaming releaseRef to leakRef.
Comment 1 Darin Adler 2011-11-10 08:26:52 PST 
Created attachment 114508 [details]
Patch
Comment 2 Julien Chaffraix 2011-11-10 12:05:56 PST 
Comment on attachment 114508 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=114508&action=review

> Source/JavaScriptCore/API/JSRetainPtr.h:-75
> -    T releaseRef() { return leakRef(); }

I guess you have discussed this API breakage.
Comment 3 Darin Adler 2011-11-10 12:07:50 PST 
(In reply to comment #2)
> I guess you have discussed this API breakage.

Is JSRetainPtr API? On what platforms?
Comment 4 Julien Chaffraix 2011-11-10 12:13:13 PST 
(In reply to comment #3)
> (In reply to comment #2)
> > I guess you have discussed this API breakage.
> 
> Is JSRetainPtr API? On what platforms?

I thought it was exposed to the JSC API but it is actually not exposed.
Comment 5 WebKit Review Bot 2011-11-11 14:52:15 PST 
Comment on attachment 114508 [details]
Patch

Clearing flags on attachment: 114508

Committed r100030: <http://trac.webkit.org/changeset/100030>
Comment 6 WebKit Review Bot 2011-11-11 14:52:19 PST 
All reviewed patches have been landed.  Closing bug.