71422 – Change remaining callers of releaseRef to call leakRef

Bug 71422 - Change remaining callers of releaseRef to call leakRef

Summary: Change remaining callers of releaseRef to call leakRef

Status:	RESOLVED FIXED

Alias:	None

Product:	WebKit
Classification:	Unclassified
Component:	WebKit Misc. (show other bugs)
Version:	528+ (Nightly build)
Hardware:	Unspecified Unspecified

Importance:	P2 Normal
Assignee:	Darin Adler

URL:
Keywords:

Depends on:
Blocks:	41374
	Show dependency tree / graph

Reported:	2011-11-02 17:08 PDT by Darin Adler
Modified:	2011-11-03 16:05 PDT (History)
CC List:	2 users (show)

See Also:

Attachments
Patch (68.83 KB, patch) 2011-11-02 17:12 PDT, Darin Adler	fishd: review+ webkit.review.bot: commit-queue-	Details \| Formatted Diff \| Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Darin Adler 2011-11-02 17:08:48 PDT

Change remaining callers of releaseRef to call leakRef

Comment 1 Darin Adler 2011-11-02 17:12:27 PDT

Created attachment 113405 [details]
Patch

Comment 2 WebKit Review Bot 2011-11-02 17:16:01 PDT

Please wait for approval from fishd@chromium.org before submitting because this patch contains changes to the Chromium public API.

Comment 3 Darin Adler 2011-11-02 17:19:39 PDT

(In reply to comment #2)
> Please wait for approval from fishd@chromium.org before submitting because this patch contains changes to the Chromium public API.

No, it doesn’t. It just touches some inlined function bodies in WebPrivatePtr.h.

Comment 4 WebKit Review Bot 2011-11-03 10:22:13 PDT

Comment on attachment 113405 [details]
Patch

Rejecting attachment 113405 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 1

ERROR: /mnt/git/webkit-commit-queue/Source/JavaScriptCore/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive).

Full output: http://queues.webkit.org/results/10290026

Comment 5 Daniel Bates 2011-11-03 12:10:34 PDT

Comment on attachment 113405 [details]
Patch

Attachment 113405 [details] did not pass mac-ews (mac):
Output: http://queues.webkit.org/results/10285060

Comment 6 Darin Adler 2011-11-03 16:05:06 PDT

Committed r99239: <http://trac.webkit.org/changeset/99239>