RESOLVED FIXED 71422
Change remaining callers of releaseRef to call leakRef 
https://bugs.webkit.org/show_bug.cgi?id=71422
Summary Change remaining callers of releaseRef to call leakRef
Darin Adler
Reported 2011-11-02 17:08:48 PDT
Change remaining callers of releaseRef to call leakRef
Attachments
Patch (68.83 KB, patch)
2011-11-02 17:12 PDT, Darin Adler 		fishd: review+
webkit.review.bot: commit-queue-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Darin Adler
Comment 1 2011-11-02 17:12:27 PDT
Created attachment 113405 [details] Patch
WebKit Review Bot
Comment 2 2011-11-02 17:16:01 PDT
Please wait for approval from fishd@chromium.org before submitting because this patch contains changes to the Chromium public API.
Darin Adler
Comment 3 2011-11-02 17:19:39 PDT
(In reply to comment #2) > Please wait for approval from fishd@chromium.org before submitting because this patch contains changes to the Chromium public API. No, it doesn’t. It just touches some inlined function bodies in WebPrivatePtr.h.
WebKit Review Bot
Comment 4 2011-11-03 10:22:13 PDT
Comment on attachment 113405 [details] Patch Rejecting attachment 113405 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 1 ERROR: /mnt/git/webkit-commit-queue/Source/JavaScriptCore/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive). Full output: http://queues.webkit.org/results/10290026
Daniel Bates
Comment 5 2011-11-03 12:10:34 PDT
Comment on attachment 113405 [details] Patch Attachment 113405 [details] did not pass mac-ews (mac): Output: http://queues.webkit.org/results/10285060
Darin Adler
Comment 6 2011-11-03 16:05:06 PDT
Committed r99239: <http://trac.webkit.org/changeset/99239>
Note You need to log in before you can comment on or make changes to this bug.