Bug 71344 – Remove initMediaStreamEvent method

• Status: RESOLVED
• Resolution: FIXED
• Component: DOM

[Dominic Cooney]

This method has been removed from the spec draft:

<http://www.whatwg.org/specs/web-apps/current-work/multipage/video-conferencing-and-peer-to-peer-communication.html#mediastreamevent>

Code Search does not turn up any users: <http://codesearch.google.com/#search/&q=initMediaStreamEvent&type=cs> Since this is new, it is probably safe to remove it when MediaStreamEvent gets a constructor.

[Dominic Cooney]

Bug 71345 is tracking implementing the MediaStreamEvent constructor.

[Kaustubh Atrawalkar]

Created attachment 113649 [details]
Patch

[Kaustubh Atrawalkar]

Added patch for removing initMediaStreamEvent method.

[Dominic Cooney]

Comment on attachment 113649 [details]
Patch

The patch looks good to me. You may want to hold off landing this until the MediaStreamEvent constructor is implemented (see bug 71345) otherwise there will be no way to programatically dispatch a MediaStreamEvent.

[Adam Barth]

Comment on attachment 113649 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=113649&action=review

I think its fine to land without the constructor.  This feature isn't shipping in any port that I'm aware of.

> Source/WebCore/ChangeLog:11
> +        No new tests. Removed method.

You can test that this method doesn't exist!  That will catch us if someone tries to add it back.

[WebKit Review Bot]

Comment on attachment 113649 [details]
Patch

Clearing flags on attachment: 113649

Committed r99299: <http://trac.webkit.org/changeset/99299>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.