Bug 71253 - [Qt] 4 new tests fail introduced in r98852
Summary: [Qt] 4 new tests fail introduced in r98852
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nikolas Zimmermann
URL:
Keywords: Qt, QtTriaged
Depends on: 71256 71368
Blocks: 47156
  Show dependency treegraph
 
Reported: 2011-10-31 16:52 PDT by Csaba Osztrogonác
Modified: 2011-11-11 03:57 PST (History)
6 users (show)

See Also:


Attachments
failing images (713.02 KB, patch)
2011-10-31 17:25 PDT, Csaba Osztrogonác
no flags Details | Formatted Diff | Diff
Patch (77.65 KB, patch)
2011-11-08 07:06 PST, Nikolas Zimmermann
webkit.review.bot: commit-queue-
Details | Formatted Diff | Diff
result (834.90 KB, application/x-gzip)
2011-11-08 08:06 PST, Zoltan Arvai
no flags Details
image-diff (729.19 KB, patch)
2011-11-08 08:18 PST, Zoltan Arvai
no flags Details | Formatted Diff | Diff
Fix two failing tests (2.77 KB, patch)
2011-11-09 00:57 PST, Nikolas Zimmermann
no flags Details | Formatted Diff | Diff
image-diff2 (709.83 KB, patch)
2011-11-11 03:19 PST, Zoltan Arvai
no flags Details | Formatted Diff | Diff
Patch (2.77 KB, patch)
2011-11-11 03:41 PST, Nikolas Zimmermann
zherczeg: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Csaba Osztrogonác 2011-10-31 16:52:53 PDT
svg/zoom/page/zoom-background-images.html
svg/zoom/page/zoom-img-preserveAspectRatio-support-1.html
svg/zoom/page/zoom-svg-as-background-with-relative-size.html
fast/backgrounds/size/contain-and-cover-zoomed.html
Comment 1 Csaba Osztrogonác 2011-10-31 17:11:07 PDT
Added to the Skipped list: http://trac.webkit.org/changeset/98918
Comment 2 Csaba Osztrogonác 2011-10-31 17:23:06 PDT
(In reply to comment #1)
> Added to the Skipped list: http://trac.webkit.org/changeset/98918

Ooops, I broke it. Real skip landed in http://trac.webkit.org/changeset/98920.
Comment 3 Csaba Osztrogonác 2011-10-31 17:25:02 PDT
Created attachment 113112 [details]
failing images
Comment 4 Nikolas Zimmermann 2011-11-08 03:52:48 PST
I hope it works again for Qt since r99543. Can anyone confirm?
Comment 5 Csaba Osztrogonác 2011-11-08 05:29:12 PST
(In reply to comment #4)
> I hope it works again for Qt since r99543. Can anyone confirm?

Zoltán checked it and we got same results as the attached diff.
Comment 6 Nikolas Zimmermann 2011-11-08 06:22:42 PST
(In reply to comment #3)
> Created an attachment (id=113112) [details]
> failing images
Could you reupload this in a way its viewable? as SVN user I'm not sure what to do with your patch.
Comment 7 Csaba Osztrogonác 2011-11-08 06:24:15 PST
(In reply to comment #6)
> (In reply to comment #3)
> > Created an attachment (id=113112) [details] [details]
> > failing images
> Could you reupload this in a way its viewable? as SVN user I'm not sure what to do with your patch.

Just click here: https://bugs.webkit.org/attachment.cgi?id=113112&action=review

red one is Mac png and green one in actual png on Qt.
Comment 8 Nikolas Zimmermann 2011-11-08 06:42:06 PST
(In reply to comment #7) 
> Just click here: https://bugs.webkit.org/attachment.cgi?id=113112&action=review.
Ah great!

So here's the analysis:
> svg/zoom/page/zoom-img-preserveAspectRatio-support-1.html
This flakiness is known, and tracked by another bug, will look it up.

> svg/zoom/page/zoom-background-images.html
> svg/zoom/page/zoom-svg-as-background-with-relative-size.html
Difference between Qt/DRT and Mac/DRT.

#define MinimumZoomMultiplier       0.5f
#define MaximumZoomMultiplier       3.0f
#define ZoomMultiplierRatio         1.2f

We can only zoom in three times from DRT/Mac, zooming in 4 or 5 or 6 times, results in a scale factor < 0.5f, and is thus ignored!

I'll fix the test, to avoid zooming in four times.

> fast/backgrounds/size/contain-and-cover-zoomed.html
Real regression, not sure what happens.
Comment 9 Nikolas Zimmermann 2011-11-08 07:06:28 PST
Created attachment 114058 [details]
Patch

Fix zoom problems.
Comment 10 Rob Buis 2011-11-08 07:15:13 PST
Comment on attachment 114058 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=114058&action=review

LGTM

> LayoutTests/ChangeLog:8
> +        Adress some problems seen on Qt/Chromium:

Address

> LayoutTests/ChangeLog:10
> +        - Don't zoom out more than three times, otherwhise its ignored on Mac/DRT, where the minimum zoom factor is clamped to 0.5f.

Otherwise
Comment 11 Nikolas Zimmermann 2011-11-08 07:16:45 PST
Comment on attachment 114058 [details]
Patch

Landed in r99566. Can anyone with a Qt build retry please? :-)
Comment 12 WebKit Review Bot 2011-11-08 07:43:41 PST
Comment on attachment 114058 [details]
Patch

Attachment 114058 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/10370086

New failing tests:
svg/zoom/page/zoom-replaced-intrinsic-ratio-001.htm
Comment 13 Zoltan Arvai 2011-11-08 08:06:11 PST
Created attachment 114071 [details]
result

Still failing with r99569.
Comment 14 Csaba Osztrogonác 2011-11-08 08:12:32 PST
(In reply to comment #13)
> Created an attachment (id=114071) [details]
> result
> 
> Still failing with r99569.

Could you upload it again in a different format?

$old-run-webkit-tests --platform mac -p --reset-results --add-platform-exceptions TEST_NAMES

and then upload patch from "git diff --binary HEAD"
Comment 15 Zoltan Arvai 2011-11-08 08:18:52 PST
Created attachment 114078 [details]
image-diff

r99569 layout diff
Comment 16 Nikolas Zimmermann 2011-11-08 08:27:27 PST
Landed a rebaseline in r99572. I think there's one failure remaining only.
I filed bug 71673 for the remaining issue with zooming SVGs in <object>.
Comment 17 Csaba Osztrogonác 2011-11-08 23:16:07 PST
(In reply to comment #16)
> Landed a rebaseline in r99572. I think there's one failure remaining only.
> I filed bug 71673 for the remaining issue with zooming SVGs in <object>.

fast/backgrounds/size/contain-and-cover-zoomed.html still fails, because squirrelfish is still missin on the Qt png.
Comment 18 Nikolas Zimmermann 2011-11-09 00:57:23 PST
Created attachment 114219 [details]
Fix two failing tests
Comment 19 Nikolas Zimmermann 2011-11-09 01:14:35 PST
Comment on attachment 114219 [details]
Fix two failing tests

Oops, this belongs to bug 71830, sorry for the confusion.
Comment 20 Nikolas Zimmermann 2011-11-10 12:52:39 PST
Can anyone update me, if there are still problems on Qt? The squirrelfish issue is still not solved, I guess?
Comment 21 Zoltan Arvai 2011-11-10 14:22:12 PST
No change with r99898. The results are the same as image-diff patch shows.
Comment 22 Nikolas Zimmermann 2011-11-11 02:35:03 PST
(In reply to comment #21)
> No change with r99898. The results are the same as image-diff patch shows.

zoom-img-preserveAspectRatio-support-1 problem should be fixed by r99937.
I think the only remaining failure is contain-and-cover-zoomed for Qt.

Hm, could you open it manually with a Browser, and then zoom in.
I guess Squirrelfish appears, but then disappears after zooming, is that right?
Comment 23 Zoltan Arvai 2011-11-11 03:19:17 PST
Created attachment 114659 [details]
image-diff2

I tried it with QtTestBrowser from r99937. 

There is a problem with the LayoutTests/fast/backgrounds/size/resources/SquirrelFish.svg: 
<?xml version="1." standalone="no"?>
A zero is missing from the version.

I uplodaed image-diff2 that shows the differencies with corrected svg file.
Comment 24 Nikolas Zimmermann 2011-11-11 03:30:21 PST
(In reply to comment #23)
> Created an attachment (id=114659) [details]
> image-diff2
> 
> I tried it with QtTestBrowser from r99937. 
> 
> There is a problem with the LayoutTests/fast/backgrounds/size/resources/SquirrelFish.svg: 
> <?xml version="1." standalone="no"?>
> A zero is missing from the version.
> 
> I uplodaed image-diff2 that shows the differencies with corrected svg file.

Ah perfect! I forgot to fix contain-and-cover-zoomed.html - it still zomes out 4 times, instead of 3 times, which is ignored on Mac. Will upload a patch containing your fix as well to SquirrelFish.svg
That's it we're finished :-)
Comment 25 Nikolas Zimmermann 2011-11-11 03:33:54 PST
(In reply to comment #23)
> There is a problem with the LayoutTests/fast/backgrounds/size/resources/SquirrelFish.svg: 
I just wonder: shouldn't this affect fast/backgrounds/size/contain-and-cover.html as well? Is this skipped for Qt?
Comment 26 Nikolas Zimmermann 2011-11-11 03:41:08 PST
Created attachment 114663 [details]
Patch
Comment 27 Zoltan Herczeg 2011-11-11 03:45:14 PST
Comment on attachment 114663 [details]
Patch

r=me
Comment 28 Nikolas Zimmermann 2011-11-11 03:51:41 PST
Landed in r99941. This will require rebaelines for gtk/qt/chromium, I think.
Comment 29 Zoltan Arvai 2011-11-11 03:57:55 PST
(In reply to comment #25)
> (In reply to comment #23)
> > There is a problem with the LayoutTests/fast/backgrounds/size/resources/SquirrelFish.svg: 
> I just wonder: shouldn't this affect fast/backgrounds/size/contain-and-cover.html as well? Is this skipped for Qt?

Its not on qt skip list. But it was also affected by this issue.
run-webkit-tests -p --platform mac fast/backgrounds/size/contain-and-cover.html was failing with buggy svg file (diff 18%). With corrected svg there is only 0.01% diff.