Bug 71156 - More work on WebKit2 should respect WebKitOmitPDFSupport preference on the Mac
Summary: More work on WebKit2 should respect WebKitOmitPDFSupport preference on the Mac
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jeff Miller
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-10-28 16:04 PDT by Jeff Miller
Modified: 2011-10-28 16:35 PDT (History)
1 user (show)

See Also:


Attachments
Patch (1.82 KB, patch)
2011-10-28 16:08 PDT, Jeff Miller
ap: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jeff Miller 2011-10-28 16:04:14 PDT
More work on WebKit2 should respect WebKitOmitPDFSupport preference on the Mac
Comment 1 Jeff Miller 2011-10-28 16:05:28 PDT
Follow up to bug 70943, where Alexey commented:


> There is also PDF code in WebContext::platformInitializeWebProcess. Should that be conditional, too?
Comment 2 Jeff Miller 2011-10-28 16:08:28 PDT
Created attachment 112936 [details]
Patch
Comment 3 Alexey Proskuryakov 2011-10-28 16:18:54 PDT
Comment on attachment 112936 [details]
Patch

What was the manifestation of this problem, and are we sure that omitPDFSupport() will return the correct result so early in context lifetime?
Comment 4 Jeff Miller 2011-10-28 16:31:29 PDT
(In reply to comment #3)
> (From update of attachment 112936 [details])
> What was the manifestation of this problem, and are we sure that omitPDFSupport() will return the correct result so early in context lifetime?

There was no end-user symptom, PDF support was disabled correctly when this pref was set with the previous patch in r98513. This is just being complete by not including these MIME types in the initialization message.

omitPDFSupport() just reads a preference from the standard user defaults, which should definitely be OK when this is called (note that this code is in the UI process, not the web process which is being created).
Comment 5 Jeff Miller 2011-10-28 16:35:19 PDT
Committed r98781: <http://trac.webkit.org/changeset/98781>