Bug 70943 - WebKit2 should respect WebKitOmitPDFSupport preference on the Mac
Summary: WebKit2 should respect WebKitOmitPDFSupport preference on the Mac
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: 528+ (Nightly build)
Hardware: Mac All
: P2 Normal
Assignee: Jeff Miller
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2011-10-26 10:52 PDT by Jeff Miller
Modified: 2011-10-28 16:04 PDT (History)
4 users (show)

See Also:

Attachments
Patch (3.31 KB, patch)
2011-10-26 10:58 PDT, Jeff Miller 		ap: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jeff Miller 2011-10-26 10:52:51 PDT 
This is a regression from WebKit1.
Comment 1 Jeff Miller 2011-10-26 10:53:05 PDT 
<rdar://problem/10333309> REGRESSION: WebKitOmitPDFSupport default lost in WebKit2
Comment 2 Jeff Miller 2011-10-26 10:58:14 PDT 
Created attachment 112565 [details]
Patch
Comment 3 Alexey Proskuryakov 2011-10-26 11:32:13 PDT 
Comment on attachment 112565 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=112565&action=review

> Source/WebKit2/ChangeLog:6
> +        Don't register built-in PDF plugin if WebKitOmitPDFSupport pref is set.

This explanation is slightly misleading, as the patch disables both the new "plug-in" for subframes and the PDFKit-based support for main frame only.
Comment 4 Jeff Miller 2011-10-26 13:19:26 PDT 
Committed r98513: <http://trac.webkit.org/changeset/98513>
Comment 5 Alexey Proskuryakov 2011-10-28 14:53:57 PDT 
There is also PDF code in WebContext::platformInitializeWebProcess. Should that be conditional, too?
Comment 6 Jeff Miller 2011-10-28 15:59:12 PDT 
(In reply to comment #5)
> There is also PDF code in WebContext::platformInitializeWebProcess. Should that be conditional, too?

Probably, although PDF viewing seems to be disabled with just r98513. I'll file another bug to fix this.
Comment 7 Jeff Miller 2011-10-28 16:04:35 PDT 
(In reply to comment #6)
> (In reply to comment #5)
> > There is also PDF code in WebContext::platformInitializeWebProcess. Should that be conditional, too?
> 
> Probably, although PDF viewing seems to be disabled with just r98513. I'll file another bug to fix this.

Tracked by bug 71156.