Bug 70914 - [EFL] build on macosx does not work for various small reasons
Summary: [EFL] build on macosx does not work for various small reasons
Status: RESOLVED WONTFIX
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit EFL (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
: 57437 (view as bug list)
Depends on: 70913
Blocks:
  Show dependency treegraph
 
Reported: 2011-10-26 06:20 PDT by Onne Gorter
Modified: 2017-03-11 10:31 PST (History)
6 users (show)

See Also:


Attachments
small tweaks to efl macosx build (4.07 KB, patch)
2011-10-26 06:20 PDT, Onne Gorter
no flags Details | Formatted Diff | Diff
small tweaks to efl macosx build (updated) (4.41 KB, patch)
2011-10-26 06:26 PDT, Onne Gorter
no flags Details | Formatted Diff | Diff
add -DU_DISABLE_RENAME for icu (4.74 KB, patch)
2011-10-27 01:40 PDT, Onne Gorter
gyuyoung.kim: review-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Onne Gorter 2011-10-26 06:20:46 PDT
Created attachment 112495 [details]
small tweaks to efl macosx build

on MAC it will set PLATFORM(MAC) which implies way too much apple port specific things, disabled in Platform.h
for threading we need to link libobjc.dylib
efl depends on FONTCONFIG and PNG and JPEG libraries too, macosx won't do implicit linking like linux
stop using 1.0.999 in ecore and other libs, macosx linker cannot handle that, so use 1.0.99 instead
fix ENABLE_ECORE_X flag
libicuuc is actually icucore
Comment 1 Onne Gorter 2011-10-26 06:21:22 PDT
depends on Bug 70913 , unless you compile on a case sensitive drive
Comment 2 Onne Gorter 2011-10-26 06:26:52 PDT
Created attachment 112499 [details]
small tweaks to efl macosx build (updated)
Comment 3 Onne Gorter 2011-10-26 06:30:04 PDT
*** Bug 57437 has been marked as a duplicate of this bug. ***
Comment 4 WebKit Review Bot 2011-10-26 06:40:35 PDT
Attachment 112499 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/wtf/CMakeLists.txt',..." exit_code: 1

Source/WebCore/platform/cairo/WidgetBackingStore.h:27:  Alphabetical sorting problem.  [build/include_order] [4]
Total errors found: 1 in 7 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 5 Onne Gorter 2011-10-27 01:40:57 PDT
Created attachment 112651 [details]
add -DU_DISABLE_RENAME for icu

refreshed the UTF8 bug, removing the RENAMING of icu, and add it to CMake declaring it as compiler flag when compiling on apple
Comment 6 WebKit Review Bot 2011-10-27 06:09:42 PDT
Attachment 112651 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/wtf/CMakeLists.txt',..." exit_code: 1

Source/WebCore/platform/cairo/WidgetBackingStore.h:27:  Alphabetical sorting problem.  [build/include_order] [4]
Total errors found: 1 in 7 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 7 Gyuyoung Kim 2011-10-27 19:24:16 PDT
Comment on attachment 112651 [details]
add -DU_DISABLE_RENAME for icu

View in context: https://bugs.webkit.org/attachment.cgi?id=112651&action=review

You miss ChangeLog for this patch. You can make ChangeLog via Tools/Script/prepare-ChangeLog script.

>> Source/WebCore/platform/cairo/WidgetBackingStore.h:27
>> +#include <cairo/cairo.h>
> 
> Alphabetical sorting problem.  [build/include_order] [4]

Please run Tools/Script/check-webkit-style script before submitting this patch.

> Source/cmake/FindEFL.cmake:7
> +  eina>=1.0.99

Why do you reduce efl library version ?
Comment 8 Michael Catanzaro 2017-03-11 10:31:53 PST
Closing this bug because the EFL port has been removed from trunk.

If you feel this bug applies to a different upstream WebKit port and was closed in error, please either update the title and reopen the bug, or leave a comment to request this.