Bug 57437 - cmake fixes to build efl port under macosx too
Summary: cmake fixes to build efl port under macosx too
Status: RESOLVED DUPLICATE of bug 70914
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit EFL (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-03-30 02:56 PDT by Onne Gorter
Modified: 2011-10-26 06:30 PDT (History)
1 user (show)

See Also:

Attachments
cmake patch to allow building under macosx (2.44 KB, patch)
2011-03-30 02:56 PDT, Onne Gorter 		no flags Details | Formatted Diff | Diff
move public destructor to wtf or wtf by itself won't link (1.83 KB, patch)
2011-03-30 02:58 PDT, Onne Gorter 		no flags Details | Formatted Diff | Diff
cmake macosx build fix (Efl port) (2.38 KB, patch)
2011-03-30 06:55 PDT, Onne Gorter 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Onne Gorter 2011-03-30 02:56:47 PDT 
Created attachment 87490 [details]
cmake patch to allow building under macosx

there are a few issues that prevent the efl port to build under macosx, this fixes most of them, though manually fixing up wtf/Platform.h is likely required ...

two independed patches:

one to fix the cmake files to behave a bit bitter, should work and be useful under linux too

one to fix (temporary) weird layering issue in wtf vs jsc on IdentifierTable, likely fixed in the future already, only needed when compiling with shared core
Comment 1 Onne Gorter 2011-03-30 02:58:14 PDT 
Created attachment 87491 [details]
move public destructor to wtf or wtf by itself won't link
Comment 2 Onne Gorter 2011-03-30 06:36:50 PDT 
actually, you can only build webkit with ICU on a case sensitive file system! Because JavaScriptCore/wtf/unicode/UTF8.h and <unicode/utf8.h> from ICU will be ambiguous.

(Don't make the whole macosx harddrive case sensitive, this will break certain programs, instead create a disk image with a case sensitive partition.)

to make the rest work, in wtf/Platform.h:
#define WTF_PLATFORM_MAC 0
#define ENABLE_PURGEABLE_MEMORY 0

or (haven't tried) add WebCore/platform/mac/PurgeableBufferMac.cpp to WebCore/CMakeLists.txt

will update cmake patch
Comment 3 Onne Gorter 2011-03-30 06:55:49 PDT 
Created attachment 87526 [details]
cmake macosx build fix (Efl port)
Comment 4 Raphael Kubo da Costa (:rakuco) 2011-05-27 11:40:16 PDT 
Hi there. Please attach only one patch per bug, so that when it is committed the bug can be automatically closed.

You should add some people to the CC list for it to be reviewed (it's easier if you use the webkit-patch script in Tools/Scripts). You also need to mark you patch for review and commit-queue (by clicking in the "Details" link) so that it is tested against various ports.

Can you then create more bug reports if needed and check if your patches build against the latest SVN revision?
Comment 5 Onne Gorter 2011-10-26 06:30:04 PDT 
filed a newer updated bug, the patches there applies cleanly to trunk

*** This bug has been marked as a duplicate of bug 70914 ***