Bug 70908 - [GTK] Remove g_thread_init() calls from gtk-doc scanner too
Summary: [GTK] Remove g_thread_init() calls from gtk-doc scanner too
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Linux
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-10-26 05:26 PDT by Carlos Garcia Campos
Modified: 2011-10-26 05:38 PDT (History)
2 users (show)

See Also:


Attachments
Patch (2.39 KB, patch)
2011-10-26 05:28 PDT, Carlos Garcia Campos
gustavo: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Carlos Garcia Campos 2011-10-26 05:26:38 PDT
I forgot to remove g_thread_init from gtk-doc scanner too. See also bug #70717
Comment 1 Carlos Garcia Campos 2011-10-26 05:28:42 PDT
Created attachment 112484 [details]
Patch
Comment 2 Gustavo Noronha (kov) 2011-10-26 05:30:09 PDT
Comment on attachment 112484 [details]
Patch

Do we already depend (via configure.ac) on a new enough glib, btw? Worth double checking, LGTM otherwise!
Comment 3 WebKit Review Bot 2011-10-26 05:30:16 PDT
Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API
Comment 4 Carlos Garcia Campos 2011-10-26 05:35:40 PDT
(In reply to comment #2)
> (From update of attachment 112484 [details])
> Do we already depend (via configure.ac) on a new enough glib, btw? Worth double checking, LGTM otherwise!

Yes, we already checked it for bug #70717. Thanks!
Comment 5 Carlos Garcia Campos 2011-10-26 05:38:14 PDT
Committed r98465: <http://trac.webkit.org/changeset/98465>