Bug 70717 - [GTK] Remove g_thread_init() calls
Summary: [GTK] Remove g_thread_init() calls
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Linux
: P2 Normal
Assignee: Nobody
Depends on:
Reported: 2011-10-24 04:13 PDT by Carlos Garcia Campos
Modified: 2011-10-25 13:07 PDT (History)
5 users (show)

See Also:

Patch (16.54 KB, patch)
2011-10-24 04:38 PDT, Carlos Garcia Campos
no flags Details | Formatted Diff | Diff
Updated patch (16.57 KB, patch)
2011-10-24 06:51 PDT, Carlos Garcia Campos
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Carlos Garcia Campos 2011-10-24 04:13:40 PDT
With newer glib it's not needed anymore and with previous versions it was already called by g_type_init().
Comment 1 Carlos Garcia Campos 2011-10-24 04:38:17 PDT
Created attachment 112174 [details]
Comment 2 WebKit Review Bot 2011-10-24 04:41:21 PDT
Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API
Comment 3 Xan Lopez 2011-10-24 06:30:53 PDT
(In reply to comment #1)
> Created an attachment (id=112174) [details]
> Patch


- The MiniBrowser is not calling gtk_init right now, so this patch would be wrong as it is. We need to call gtk_init there (as we should have since day 0 anyway, it's a gtk app).

- Calling g_thread_init very late in the game is only officially accepted since http://git.gnome.org/browse/glib/commit/?id=0df3ca8f9bbb624b219ecdb25d3fe8aa4a51d953. With this patch we'll rely an g_type_init doing it, as Carlos says.
Comment 4 Carlos Garcia Campos 2011-10-24 06:51:11 PDT
Created attachment 112180 [details]
Updated patch

Call gtk_init() in MiniBrowser main file.
Comment 5 Xan Lopez 2011-10-24 07:17:06 PDT
Comment on attachment 112180 [details]
Updated patch

Comment 6 Carlos Garcia Campos 2011-10-24 07:55:54 PDT
Committed r98239: <http://trac.webkit.org/changeset/98239>
Comment 7 Martin Robinson 2011-10-25 13:07:46 PDT
Comment on attachment 112180 [details]
Updated patch

Clearing review flag.