Bug 70794 - Need to implement flex-line-pack
Summary: Need to implement flex-line-pack
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Tony Chang
URL:
Keywords:
: 80328 (view as bug list)
Depends on: 81427
Blocks: 62048
  Show dependency tree / graph
 
Reported: 2011-10-24 19:29 PDT by Ojan Vafai
Modified: 2012-03-29 10:16 PDT (History)
1 user (show)

See Also:

Attachments
Patch (42.52 KB, patch)
2012-03-28 17:17 PDT, Tony Chang 		ojan: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Comment 1 Tony Chang 2012-03-16 10:40:38 PDT 
*** Bug 80328 has been marked as a duplicate of this bug. ***
Comment 2 Tony Chang 2012-03-28 17:17:14 PDT 
Created attachment 134454 [details]
Patch
Comment 3 Ojan Vafai 2012-03-28 19:35:24 PDT 
Comment on attachment 134454 [details]
Patch

I'm amazed how simple this patch is after all your refactors. It took me a couple reads to understand how setting crossAxisExtent/crossAxisOffset just makes everything magically work. I'm not sure how to make it any more clear though.
Comment 4 Tony Chang 2012-03-29 10:16:55 PDT 
Committed r112544: <http://trac.webkit.org/changeset/112544>