Bug 70519 - [Chromium] Fixed Layout API needs to check that a FrameView has been created to avoid segfaults
Summary: [Chromium] Fixed Layout API needs to check that a FrameView has been created ...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Fady Samuel
URL:
Keywords:
Depends on:
Blocks: 70559
  Show dependency treegraph
 
Reported: 2011-10-20 09:54 PDT by Fady Samuel
Modified: 2011-10-20 19:36 PDT (History)
2 users (show)

See Also:


Attachments
Patch (2.42 KB, patch)
2011-10-20 17:05 PDT, Fady Samuel
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Fady Samuel 2011-10-20 09:54:35 PDT
Relatively straightforward problem and fix. Will post patch shortly.
Comment 1 Fady Samuel 2011-10-20 17:05:25 PDT
Created attachment 111874 [details]
Patch
Comment 2 Adam Barth 2011-10-20 17:07:45 PDT
Comment on attachment 111874 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=111874&action=review

> Source/WebKit/chromium/ChangeLog:9
> +        Simple patch. Upcoming patches for https://bugs.webkit.org/show_bug.cgi?id=70559 will make
> +        use of these methods in certain situations where the main frame doesn't yet have a FrameView.

Ok.  Please add tests for these branches as part of those bugs.
Comment 3 Fady Samuel 2011-10-20 17:09:11 PDT
(In reply to comment #2)
> (From update of attachment 111874 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=111874&action=review
> 
> > Source/WebKit/chromium/ChangeLog:9
> > +        Simple patch. Upcoming patches for https://bugs.webkit.org/show_bug.cgi?id=70559 will make
> > +        use of these methods in certain situations where the main frame doesn't yet have a FrameView.
> 
> Ok.  Please add tests for these branches as part of those bugs.

Will do, building a test suite is one of the blockers for the master bug. :-)
Comment 4 WebKit Review Bot 2011-10-20 19:36:09 PDT
Comment on attachment 111874 [details]
Patch

Clearing flags on attachment: 111874

Committed r98059: <http://trac.webkit.org/changeset/98059>
Comment 5 WebKit Review Bot 2011-10-20 19:36:13 PDT
All reviewed patches have been landed.  Closing bug.