70312 – [EFL][WK2] Added missing files to build WebKit2 EFL

Bug 70312 - [EFL][WK2] Added missing files to build WebKit2 EFL

Summary: [EFL][WK2] Added missing files to build WebKit2 EFL

Attachments
Patch (1.14 KB, patch) 2011-10-18 00:25 PDT, Tomasz Morawski	no flags	Details \| Formatted Diff \| Diff
Patch 2 (1.33 KB, patch) 2011-10-18 06:41 PDT, Tomasz Morawski	no flags	Details \| Formatted Diff \| Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Tomasz Morawski 2011-10-18 00:22:51 PDT

Added missing files to build WebKit2 EFL to fix few linking time errors.

Comment 1 Tomasz Morawski 2011-10-18 00:25:30 PDT

Created attachment 111400 [details]
Patch

Comment 2 Leandro Pereira 2011-10-18 06:28:19 PDT

Comment on attachment 111400 [details]
Patch

LGTM. Just a minor nit: I'd comment which files were added to CMakeListsEfl.txt in the changelog entry.

Comment 3 Tomasz Morawski 2011-10-18 06:41:59 PDT

Created attachment 111432 [details]
Patch 2

Comment 4 Tomasz Morawski 2011-10-18 06:42:43 PDT

> Just a minor nit: I'd comment which files were added to CMakeListsEfl.txt in the changelog entry
Chamgelog has been changed.

Comment 5 Ryosuke Niwa 2011-10-18 23:41:54 PDT

Comment on attachment 111432 [details]
Patch 2 

You didn't svn add files :(

Comment 6 Ryosuke Niwa 2011-10-18 23:43:22 PDT

Comment on attachment 111432 [details]
Patch 2 

Oops I take back. These files do exist. r=me.

Comment 7 WebKit Review Bot 2011-10-19 01:31:37 PDT

Comment on attachment 111432 [details]
Patch 2 

Clearing flags on attachment: 111432

Committed r97841: <http://trac.webkit.org/changeset/97841>

Comment 8 WebKit Review Bot 2011-10-19 01:31:41 PDT

All reviewed patches have been landed.  Closing bug.