Bug 70219 – Test :visited pseudo class

• Status: RESOLVED
• Resolution: FIXED
• Component: CSS

[Antti Koivisto]

Currently DRT doesn't support :visited. All tests where it should match have wrong checked in results.

[Antti Koivisto]

Created attachment 111223 [details]
patch

[WebKit Review Bot]

Attachment 111223 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'LayoutTests/plat..." exit_code: 1

Source/WebCore/rendering/RenderTreeAsText.cpp:290:  Boolean expressions that span multiple lines should have their operators on the left side of the line instead of the right side.  [whitespace/operators] [4]
Source/WebCore/rendering/RenderTreeAsText.cpp:296:  Boolean expressions that span multiple lines should have their operators on the left side of the line instead of the right side.  [whitespace/operators] [4]
Source/WebCore/rendering/RenderTreeAsText.cpp:301:  Boolean expressions that span multiple lines should have their operators on the left side of the line instead of the right side.  [whitespace/operators] [4]
Total errors found: 3 in 14 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Andreas Kling]

Comment on attachment 111223 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=111223&action=review

r=me, though consider cleaning up the style. I know it matches the surrounding code, but meh.


As discussed on IRC, we should probably also be dumping visited state dependent colors for borders, etc. I suspect that will require new tests though.

> Source/WebCore/ChangeLog:11
> +          for :visited use it already, the rest can be modified to use it.

to match -> match

[Eric Seidel (no email)]

Attachment 111223 [details] was posted by a committer and has review+, assigning to Antti Koivisto for commit.

The patch was committed in r97596, and introduced unpredictable variability in tests results (bug 81696). I see that the bug is still open. Is the intent to revert the change, or fix the remaining issues?

[Antti Koivisto]

I just forgot to close this.

http://trac.webkit.org/changeset/97596