Bug 70219 - Test :visited pseudo class
Summary: Test :visited pseudo class
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Antti Koivisto
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-10-17 01:10 PDT by Antti Koivisto
Modified: 2012-03-20 14:43 PDT (History)
4 users (show)

See Also:


Attachments
patch (23.69 KB, patch)
2011-10-17 01:20 PDT, Antti Koivisto
kling: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Antti Koivisto 2011-10-17 01:10:11 PDT
Currently DRT doesn't support :visited. All tests where it should match have wrong checked in results.
Comment 1 Antti Koivisto 2011-10-17 01:20:34 PDT
Created attachment 111223 [details]
patch
Comment 2 WebKit Review Bot 2011-10-17 01:22:11 PDT
Attachment 111223 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'LayoutTests/plat..." exit_code: 1

Source/WebCore/rendering/RenderTreeAsText.cpp:290:  Boolean expressions that span multiple lines should have their operators on the left side of the line instead of the right side.  [whitespace/operators] [4]
Source/WebCore/rendering/RenderTreeAsText.cpp:296:  Boolean expressions that span multiple lines should have their operators on the left side of the line instead of the right side.  [whitespace/operators] [4]
Source/WebCore/rendering/RenderTreeAsText.cpp:301:  Boolean expressions that span multiple lines should have their operators on the left side of the line instead of the right side.  [whitespace/operators] [4]
Total errors found: 3 in 14 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Andreas Kling 2011-10-17 01:58:15 PDT
Comment on attachment 111223 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=111223&action=review

r=me, though consider cleaning up the style. I know it matches the surrounding code, but meh.


As discussed on IRC, we should probably also be dumping visited state dependent colors for borders, etc. I suspect that will require new tests though.

> Source/WebCore/ChangeLog:11
> +          for :visited use it already, the rest can be modified to use it.

to match -> match
Comment 4 Eric Seidel (no email) 2011-12-21 14:30:19 PST
Attachment 111223 [details] was posted by a committer and has review+, assigning to Antti Koivisto for commit.
Comment 5 mitz 2012-03-20 13:48:29 PDT
The patch was committed in r97596, and introduced unpredictable variability in tests results (bug 81696). I see that the bug is still open. Is the intent to revert the change, or fix the remaining issues?
Comment 6 Antti Koivisto 2012-03-20 14:43:18 PDT
I just forgot to close this.

http://trac.webkit.org/changeset/97596