Bug 81696 - REGRESSION (r97596): Enabling :visited in layout test is not compatible with running arbitrary subsets of tests in arbitrary order
Summary: REGRESSION (r97596): Enabling :visited in layout test is not compatible with ...
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P1 Normal
Assignee: mitz
URL:
Keywords: InRadar, LayoutTestFailure, Regression
Depends on:
Blocks:
 
Reported: 2012-03-20 13:46 PDT by mitz
Modified: 2012-03-27 13:17 PDT (History)
6 users (show)

See Also:


Attachments
Work around test failures caused by this issue in some fast/block tests (12.82 KB, patch)
2012-03-20 14:05 PDT, mitz
jberlin: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description mitz 2012-03-20 13:46:27 PDT
<http://trac.webkit.org/r97596> made render tree dumps expose visited link styling. When using run-webkit-tests, which URLs are visited when a given test is run is arbitrary (it depends on things such as the number of instances of the test program running, the number of tests before a given test, and the subset of tests being run), so results are inconsistent.
Comment 1 Radar WebKit Bug Importer 2012-03-20 13:47:28 PDT
<rdar://problem/11084564>
Comment 2 mitz 2012-03-20 14:05:36 PDT
Created attachment 132892 [details]
Work around test failures caused by this issue in some fast/block tests
Comment 3 Jessie Berlin 2012-03-20 14:17:38 PDT
Comment on attachment 132892 [details]
Work around test failures caused by this issue in some fast/block tests

On IRC, Dan assured me that there are no other platform-specific or cross platform results that need to be updated.
Comment 4 mitz 2012-03-20 14:20:06 PDT
Committed attachment 132892 [details] as in <http://trac.webkit.org/r111437>.
Comment 5 mitz 2012-03-24 10:15:25 PDT
fast/block/float/float-in-float-hit-testing.html is another test affected by this
Comment 6 mitz 2012-03-24 10:20:58 PDT
(In reply to comment #5)
> fast/block/float/float-in-float-hit-testing.html is another test affected by this

although the problem there seems to be inconsistency between DumpRenderTree and WebKitTestRunner.
Comment 7 Eric Seidel (no email) 2012-03-27 12:34:09 PDT
Attachment 132892 [details] was posted by a committer and has review+, assigning to Dan Bernstein for commit.
Comment 8 mitz 2012-03-27 13:14:25 PDT
(In reply to comment #7)
> Attachment 132892 [details] was posted by a committer and has review+, assigning to Dan Bernstein for commit.

See comment #4, which states specifically the attachment and the revision in which it was committed.
Comment 9 Eric Seidel (no email) 2012-03-27 13:16:00 PDT
It's just my automated script, assigning patches to committers if they're in the commit queue.

I assume that since this has been committed it should be closed?
Comment 10 Eric Seidel (no email) 2012-03-27 13:16:30 PDT
Or alternatively, we should obsolete the above patch now that its' been landed (since I assume you're waiting for hte actual regression to be fixed?)
Comment 11 Eric Seidel (no email) 2012-03-27 13:17:24 PDT
(None of this is a big deal.  Just explaining why the scripts (and people) see this patch as being in the pending-commit list.)