Bug 70211 – Initial plumbing for vertical writing mode form controls

• Status: RESOLVED
• Resolution: FIXED
• Component: Forms

[SiqinBilige]

I am tested -moz-writing-mode:vertical-lr for traditional mongolian language on windiws 7.
The displaying was allwrite (top-bottom,left-right).
But with forms ( textarea, input.text, select ) it was not correctly.
It is correctly display the data and it's directions.
but can not sizeing the form component correctly.
I use the css width height to resize the components, but no effect on it.
The result image was attached and the page can view on URL.
(sorry for my bad english).

[SiqinBilige]

Created attachment 111199 [details]
Mongolian Forms

[Alexey Proskuryakov]

Created attachment 111294 [details]
another test case

Attaching another test case, which shows that Roman letters also don't work in vertical writing mode.

[SiqinBilige]

sorry.
there is mistake in my description.
  wrong : -moz-writing-mode:vertical-lr
  right : -webkit-writing-mode: vertical-lr

[Alexey Proskuryakov]

<rdar://problem/12072686>

[SiqinBilige]

On WebKit r131444 we can sizing textarea but can not display traditional mongolian script by vertical with -webkit-writing-mode: vertical-lr.
It is both on Windows and Mac OS X(WebKit r131535).

[Dave Hyatt]

We'll probably want to split this out by control, since it's going to involve different patches to make each control work properly.

[Dave Hyatt]

Created attachment 192264 [details]
Patch that makes text controls work with vertical writing.

[Dave Hyatt]

The attached patch fixes up textfields and textareas to work with vertical writing.

[Dave Hyatt]

Created attachment 192273 [details]
Patch for input and textarea

[WebKit Review Bot]

Attachment 192273 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/css/html.css', u'Source/WebCore/rendering/RenderBoxModelObject.h', u'Source/WebCore/rendering/RenderSearchField.cpp', u'Source/WebCore/rendering/RenderSearchField.h', u'Source/WebCore/rendering/RenderTextControl.cpp', u'Source/WebCore/rendering/RenderTextControl.h', u'Source/WebCore/rendering/RenderTextControlMultiLine.cpp', u'Source/WebCore/rendering/RenderTextControlMultiLine.h', u'Source/WebCore/rendering/RenderTextControlSingleLine.cpp', u'Source/WebCore/rendering/RenderTextControlSingleLine.h', u'Source/WebCore/rendering/style/RenderStyle.h']" exit_code: 1
Source/WebCore/rendering/RenderTextControlSingleLine.cpp:330:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/WebCore/rendering/style/RenderStyle.h:990:  One line control clauses should not use braces.  [whitespace/braces] [4]
Source/WebCore/rendering/style/RenderStyle.h:992:  One line control clauses should not use braces.  [whitespace/braces] [4]
Source/WebCore/rendering/style/RenderStyle.h:999:  One line control clauses should not use braces.  [whitespace/braces] [4]
Source/WebCore/rendering/style/RenderStyle.h:1001:  One line control clauses should not use braces.  [whitespace/braces] [4]
Total errors found: 5 in 11 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[WebKit Review Bot]

Comment on attachment 192273 [details]
Patch for input and textarea

Attachment 192273 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://webkit-commit-queue.appspot.com/results/17110320

New failing tests:
fast/forms/search-disabled-readonly.html
fast/forms/searchfield-heights.html
fast/forms/datalist/update-range-with-datalist.html
fast/forms/placeholder-pseudo-style.html
fast/hidpi/video-controls-in-hidpi.html
http/tests/cache/subresource-failover-to-network.html
fast/forms/search-zoomed.html
fast/forms/search-display-none-cancel-button.html
fast/forms/search-cancel-button-style-sharing.html
fast/forms/number/number-appearance-spinbutton-disabled-readonly.html
fast/loader/text-document-wrapping.html
fast/layers/no-clipping-overflow-hidden-added-after-transition.html
fast/css/input-search-padding.html
fast/forms/control-restrict-line-height.html
fast/forms/search-abs-pos-cancel-button.html
fast/forms/search-cancel-button-events.html
fast/forms/number/number-appearance-rtl.html
fast/css/text-input-with-webkit-border-radius.html
fast/forms/input-appearance-height.html
fast/forms/search-cancel-button-mouseup.html
fast/forms/search-transformed.html
fast/forms/number/number-appearance-spinbutton-layer.html
fast/forms/search-rtl.html
fast/forms/search-styled.html
fast/layers/no-clipping-overflow-hidden-added-after-transform.html
fast/css/text-overflow-input.html
fast/loader/javascript-url-in-object.html
fast/forms/box-shadow-override.html
fast/forms/search-vertical-alignment.html
fast/layers/no-clipping-overflow-hidden-hardware-acceleration.html

[Build Bot]

Comment on attachment 192273 [details]
Patch for input and textarea

Attachment 192273 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-commit-queue.appspot.com/results/17134076

New failing tests:
fast/forms/search-disabled-readonly.html
fast/forms/placeholder-pseudo-style.html
fast/forms/search-display-none-cancel-button.html
fast/forms/search-cancel-button-style-sharing.html
fast/forms/number/number-appearance-spinbutton-disabled-readonly.html
fast/events/autoscroll-in-textarea.html
fast/css/input-search-padding.html
editing/pasteboard/smart-paste-001.html
fast/forms/control-restrict-line-height.html
fast/forms/search-abs-pos-cancel-button.html
fast/forms/search-cancel-button-events.html
fast/forms/number/number-appearance-rtl.html
fast/css/text-input-with-webkit-border-radius.html
fast/forms/placeholder-position.html
fast/forms/input-appearance-height.html
fast/forms/search-cancel-button-mouseup.html
fast/forms/number/number-appearance-spinbutton-layer.html
fast/forms/search-rtl.html
canvas/philip/tests/2d.text.draw.fontface.notinpage.html
fast/css/text-overflow-input.html
fast/history/visited-link-background-color.html
fast/forms/box-shadow-override.html
fast/events/event-sender-mouse-moved.html

[Dave Hyatt]

Created attachment 192481 [details]
Patch

This patch simply preps the code. It doesn't turn on vertical writing yet. I'm thinking the best approach for form controls is to slowly prep the code while leaving the feature off, and then once we have them all converted, we can worry about turning this on.

[WebKit Review Bot]

Attachment 192481 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/rendering/RenderBoxModelObject.h', u'Source/WebCore/rendering/RenderSearchField.cpp', u'Source/WebCore/rendering/RenderSearchField.h', u'Source/WebCore/rendering/RenderTextControl.cpp', u'Source/WebCore/rendering/RenderTextControl.h', u'Source/WebCore/rendering/RenderTextControlMultiLine.cpp', u'Source/WebCore/rendering/RenderTextControlMultiLine.h', u'Source/WebCore/rendering/RenderTextControlSingleLine.cpp', u'Source/WebCore/rendering/RenderTextControlSingleLine.h', u'Source/WebCore/rendering/style/RenderStyle.h']" exit_code: 1
Source/WebCore/rendering/style/RenderStyle.h:990:  One line control clauses should not use braces.  [whitespace/braces] [4]
Source/WebCore/rendering/style/RenderStyle.h:992:  One line control clauses should not use braces.  [whitespace/braces] [4]
Source/WebCore/rendering/style/RenderStyle.h:999:  One line control clauses should not use braces.  [whitespace/braces] [4]
Source/WebCore/rendering/style/RenderStyle.h:1001:  One line control clauses should not use braces.  [whitespace/braces] [4]
Total errors found: 4 in 10 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Dave Hyatt]

Created attachment 192515 [details]
Patch

[WebKit Review Bot]

Attachment 192515 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCore/rendering/RenderBoxModelObject.h', u'Source/WebCore/rendering/RenderSearchField.cpp', u'Source/WebCore/rendering/RenderSearchField.h', u'Source/WebCore/rendering/RenderTextControl.cpp', u'Source/WebCore/rendering/RenderTextControl.h', u'Source/WebCore/rendering/RenderTextControlMultiLine.cpp', u'Source/WebCore/rendering/RenderTextControlMultiLine.h', u'Source/WebCore/rendering/RenderTextControlSingleLine.cpp', u'Source/WebCore/rendering/RenderTextControlSingleLine.h', u'Source/WebCore/rendering/style/RenderStyle.h']" exit_code: 1
Source/WebCore/rendering/style/RenderStyle.h:990:  One line control clauses should not use braces.  [whitespace/braces] [4]
Source/WebCore/rendering/style/RenderStyle.h:992:  One line control clauses should not use braces.  [whitespace/braces] [4]
Source/WebCore/rendering/style/RenderStyle.h:999:  One line control clauses should not use braces.  [whitespace/braces] [4]
Source/WebCore/rendering/style/RenderStyle.h:1001:  One line control clauses should not use braces.  [whitespace/braces] [4]
Total errors found: 4 in 11 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Dave Hyatt]

Created attachment 192516 [details]
Patch

[WebKit Review Bot]

Attachment 192516 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCore/rendering/RenderBoxModelObject.h', u'Source/WebCore/rendering/RenderSearchField.cpp', u'Source/WebCore/rendering/RenderSearchField.h', u'Source/WebCore/rendering/RenderTextControl.cpp', u'Source/WebCore/rendering/RenderTextControl.h', u'Source/WebCore/rendering/RenderTextControlMultiLine.cpp', u'Source/WebCore/rendering/RenderTextControlMultiLine.h', u'Source/WebCore/rendering/RenderTextControlSingleLine.cpp', u'Source/WebCore/rendering/RenderTextControlSingleLine.h', u'Source/WebCore/rendering/style/RenderStyle.h']" exit_code: 1
Source/WebCore/rendering/style/RenderStyle.h:990:  One line control clauses should not use braces.  [whitespace/braces] [4]
Source/WebCore/rendering/style/RenderStyle.h:992:  One line control clauses should not use braces.  [whitespace/braces] [4]
Source/WebCore/rendering/style/RenderStyle.h:999:  One line control clauses should not use braces.  [whitespace/braces] [4]
Source/WebCore/rendering/style/RenderStyle.h:1001:  One line control clauses should not use braces.  [whitespace/braces] [4]
Total errors found: 4 in 11 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Simon Fraser (smfr)]

Comment on attachment 192516 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=192516&action=review

> Source/WebCore/ChangeLog:11
> +        writing yet.
> +        
> +        Reviewed by NOBODY (OOPS!).

Would be nice to summarize the nature of the changes.

Reviewed by line should go above the change description.

[Dave Hyatt]

Textfield plumbing landed in r145391.

[SiqinBilige]

On r145355 (-webkit-writing-mode: vertical-lr)
1. textarea can sizing, but can not edit text vertical way.
2. text field can sizing, but can not edit text vertical way.
3. select can not sizing, can not display vertical way.
4. button can not sizing, can not display vertical way.
5. editble div can sizing and display/edit vertical way.

[SiqinBilige]

On r145768 (-webkit-writing-mode: vertical-lr)
1. textarea can sizing, but can not edit text vertical way.
2. text field can sizing, but can not edit text vertical way.
3. select can not sizing, can not display vertical way.
4. button can not sizing, can not display vertical way.
5. editble div can sizing and display/edit vertical way.

[SiqinBilige]

Created attachment 193082 [details]
evidence

r145768.png

[SiqinBilige]

Created attachment 193414 [details]
evidence

On r145930
Webkit completely can not display and edit Traditional Mongolian Language vertical way.
What is it ?

[Ryosuke Niwa]

(In reply to comment #24)
> Created an attachment (id=193414) [details]
> evidence
> 
> On r145930
> Webkit completely can not display and edit Traditional Mongolian Language vertical way.
> What is it ?

Please file a new bug.

[Tim Nguyen (:ntim)]

Let's file new bugs for further work.

[Tim Nguyen (:ntim)]

https://github.com/WebKit/WebKit/commit/f65bcef60fd613c09d7ef738f581861415bfaff6