Cues should be cached like other web resources so they should be loaded by a CachedResourceLoader
<rdar://problem/10288601>
Created attachment 111056 [details] Part 1: Update CachedResourceLoader to load cues
Created attachment 111057 [details] Part 2: Implement the cue loader
Comment on attachment 111057 [details] Part 2: Implement the cue loader Attachment 111057 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/10060651
(In reply to comment #4) > (From update of attachment 111057 [details]) > Attachment 111057 [details] did not pass chromium-ews (chromium-xvfb): > Output: http://queues.webkit.org/results/10060651 Part 2 depends on Part 1.
Comment on attachment 111057 [details] Part 2: Implement the cue loader Attachment 111057 [details] did not pass gtk-ews (gtk): Output: http://queues.webkit.org/results/10074211
(In reply to comment #6) > (From update of attachment 111057 [details]) > Attachment 111057 [details] did not pass gtk-ews (gtk): > Output: http://queues.webkit.org/results/10074211 See comment #5.
Comment on attachment 111057 [details] Part 2: Implement the cue loader Clearing flags, this won't compile without the other patch so I will create a new bug for this once the other changes land.
Created attachment 111176 [details] Patch with ChangeLog
Comment on attachment 111176 [details] Patch with ChangeLog Attachment 111176 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/10074465
Comment on attachment 111176 [details] Patch with ChangeLog Attachment 111176 [details] did not pass gtk-ews (gtk): Output: http://queues.webkit.org/results/10073548
Created attachment 111181 [details] Add new file to other build systems.
Comment on attachment 111181 [details] Add new file to other build systems. View in context: https://bugs.webkit.org/attachment.cgi?id=111181&action=review > Source/WebCore/loader/cache/CachedCues.cpp:53 > + setEncodedSize(m_data.get() ? m_data->size() : 0); Should not need a "get" here. > Source/WebCore/loader/cache/CachedCues.cpp:56 > + while (CachedResourceClient *client = walker.next()) The "*" needs to be next to the type here. > Source/WebCore/loader/cache/CachedCues.h:43 > + virtual void data(PassRefPtr<SharedBuffer> data, bool allDataReceived); Can this be private?
http://trac.webkit.org/changeset/97637
(In reply to comment #13) > (From update of attachment 111181 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=111181&action=review > > > Source/WebCore/loader/cache/CachedCues.cpp:53 > > + setEncodedSize(m_data.get() ? m_data->size() : 0); > > Should not need a "get" here. > > > Source/WebCore/loader/cache/CachedCues.cpp:56 > > + while (CachedResourceClient *client = walker.next()) > > The "*" needs to be next to the type here. > > > Source/WebCore/loader/cache/CachedCues.h:43 > > + virtual void data(PassRefPtr<SharedBuffer> data, bool allDataReceived); > > Can this be private? I missed these comments, but will do the suggested cleanup in another patch.