Bug 70073 - land-cowboy should at least check style.
Summary: land-cowboy should at least check style.
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Dimitri Glazkov (Google)
Depends on:
Reported: 2011-10-13 16:38 PDT by Dimitri Glazkov (Google)
Modified: 2011-10-14 11:25 PDT (History)
3 users (show)

See Also:

Patch (1.17 KB, patch)
2011-10-13 16:39 PDT, Dimitri Glazkov (Google)
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Dimitri Glazkov (Google) 2011-10-13 16:38:49 PDT
land-cowboy should at least check style.
Comment 1 Dimitri Glazkov (Google) 2011-10-13 16:39:25 PDT
Created attachment 110930 [details]
Comment 2 Dimitri Glazkov (Google) 2011-10-13 16:40:23 PDT
This has bitten me for the last time!
Comment 3 Adam Barth 2011-10-13 16:54:58 PDT
Comment on attachment 110930 [details]

Ok.  I relent.  In the past, my position has been that cowboys don't check style, but I have to admit now that this command has passed into more common usage and not everyone who uses it is a real cowboy.

We should a command called land-cowboy-for-realz that skips CheckStyle and ConfirmDiff.  :)
Comment 4 WebKit Review Bot 2011-10-13 17:28:24 PDT
Comment on attachment 110930 [details]

Clearing flags on attachment: 110930

Committed r97427: <http://trac.webkit.org/changeset/97427>
Comment 5 WebKit Review Bot 2011-10-13 17:28:28 PDT
All reviewed patches have been landed.  Closing bug.
Comment 6 Adam Barth 2011-10-13 22:07:42 PDT
abarth@quadzen:~/svn/webkit$ wkp land-cowboy
  Running status to find changed, added, or removed files.
  Reviewing diff to determine which lines changed.
  Change author: Adam Barth <abarth@webkit.org>.
  Running 'svn update' to update ChangeLog files.
    At revision 97439.
  Editing the LayoutTests/ChangeLog file.
-- Please remember to include a detailed description in your ChangeLog entry. --
-- See <http://webkit.org/coding/contributing.html> for more info --
LayoutTests/ChangeLog:1:  ChangeLog entry has no bug number  [changelog/bugnumber] [5]
Total errors found: 1 in 1 files
Are you sure you want to continue? [Y/n]: 
Was that diff correct? [Y/n]:
Comment 7 Adam Barth 2011-10-13 22:08:04 PDT
Can we silence that warning?  It's bogus for land-cowboy.
Comment 8 Dimitri Glazkov (Google) 2011-10-14 09:12:52 PDT
(In reply to comment #7)
> Can we silence that warning?  It's bogus for land-cowboy.

Makes sense. Lemme see what I can do.
Comment 9 Dimitri Glazkov (Google) 2011-10-14 11:25:54 PDT