Bug 70073 – land-cowboy should at least check style.

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[Dimitri Glazkov (Google)]

land-cowboy should at least check style.

[Dimitri Glazkov (Google)]

Created attachment 110930 [details]
Patch

[Dimitri Glazkov (Google)]

This has bitten me for the last time!

[Adam Barth]

Comment on attachment 110930 [details]
Patch

Ok.  I relent.  In the past, my position has been that cowboys don't check style, but I have to admit now that this command has passed into more common usage and not everyone who uses it is a real cowboy.

We should a command called land-cowboy-for-realz that skips CheckStyle and ConfirmDiff.  :)

[WebKit Review Bot]

Comment on attachment 110930 [details]
Patch

Clearing flags on attachment: 110930

Committed r97427: <http://trac.webkit.org/changeset/97427>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.

[Adam Barth]

abarth@quadzen:~/svn/webkit$ wkp land-cowboy
  Running status to find changed, added, or removed files.
  Reviewing diff to determine which lines changed.
  Change author: Adam Barth <[e-mail]>.
  Running 'svn update' to update ChangeLog files.
    At revision 97439.
  Editing the LayoutTests/ChangeLog file.
-- Please remember to include a detailed description in your ChangeLog entry. --
-- See <http://webkit.org/coding/contributing.html> for more info --
LayoutTests/ChangeLog:1:  ChangeLog entry has no bug number  [changelog/bugnumber] [5]
Total errors found: 1 in 1 files
Are you sure you want to continue? [Y/n]: 
Was that diff correct? [Y/n]:

[Adam Barth]

Can we silence that warning?  It's bogus for land-cowboy.

[Dimitri Glazkov (Google)]

(In reply to comment #7)
> Can we silence that warning?  It's bogus for land-cowboy.

Makes sense. Lemme see what I can do.

[Dimitri Glazkov (Google)]

https://bugs.webkit.org/show_bug.cgi?id=70119