Bug 70119 - Plumb style-checker filter up to command options and make land-cowboy use it.
Summary: Plumb style-checker filter up to command options and make land-cowboy use it.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Dimitri Glazkov (Google)
URL:
Keywords:
Depends on:
Blocks: 70143
  Show dependency tree / graph
 
Reported: 2011-10-14 11:22 PDT by Dimitri Glazkov (Google)
Modified: 2011-10-14 14:14 PDT (History)
3 users (show)

See Also:

Attachments
Patch (7.32 KB, patch)
2011-10-14 11:25 PDT, Dimitri Glazkov (Google) 		abarth: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dimitri Glazkov (Google) 2011-10-14 11:22:23 PDT 
Plumb style-checker filter up to command options and make land-cowboy use it.
Comment 1 Dimitri Glazkov (Google) 2011-10-14 11:25:24 PDT 
Created attachment 111032 [details]
Patch
Comment 2 Adam Barth 2011-10-14 11:31:14 PDT 
Ideally you'd set the option to non-None and check that it's being passed to the style checker appropriately, but you can skip that if you'd prefer.
Comment 3 Adam Barth 2011-10-14 11:31:24 PDT 
(I meant in a test, of course)
Comment 4 Dimitri Glazkov (Google) 2011-10-14 11:34:46 PDT 
(In reply to comment #3)
> (I meant in a test, of course)

Oooh, I should totally do this.
Comment 5 David Levin 2011-10-14 11:36:33 PDT 
Just curious, why is this being done?

(And why omit the changelog checker?)
Comment 6 David Levin 2011-10-14 11:39:27 PDT 
(In reply to comment #5)
> Just curious, why is this being done?
> 
> (And why omit the changelog checker?)
From an answer I got:
"It skips changelog check for land-cowboy since it will complain about the missing bug number."

ok
Comment 7 Dimitri Glazkov (Google) 2011-10-14 14:11:51 PDT 
Committed r97504: <http://trac.webkit.org/changeset/97504>