Bug 70063 - Fix performance of ValueToInt32 node when predicting double
Summary: Fix performance of ValueToInt32 node when predicting double
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Oliver Hunt
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-10-13 15:15 PDT by Oliver Hunt
Modified: 2011-10-14 02:50 PDT (History)
1 user (show)

See Also:


Attachments
Patch (7.65 KB, patch)
2011-10-13 15:17 PDT, Oliver Hunt
fpizlo: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Oliver Hunt 2011-10-13 15:15:15 PDT
Fix performance of ValueToInt32 node when predicting double
Comment 1 Oliver Hunt 2011-10-13 15:17:53 PDT
Created attachment 110916 [details]
Patch
Comment 2 Oliver Hunt 2011-10-13 15:23:43 PDT
Committed r97410: <http://trac.webkit.org/changeset/97410>
Comment 3 Yuqiang Xian 2011-10-13 18:17:22 PDT
--- a/Source/JavaScriptCore/dfg/DFGSpeculativeJIT32_64.cpp
+++ b/Source/JavaScriptCore/dfg/DFGSpeculativeJIT32_64.cpp
@@ -851,16 +851,7 @@ void SpeculativeJIT::compile(Node& node)
     }
 
     case ValueToInt32: {
-        if (at(node.child1()).shouldNotSpeculateInteger()) {
-            // Do it the safe way.
-            nonSpeculativeValueToInt32(node);
-            break;
-        }
-        
-        SpeculateIntegerOperand op1(this, node.child1());
-        GPRTemporary result(this, op1);
-        m_jit.move(op1.gpr(), result.gpr());
-        integerResult(result.gpr(), m_compileIndex, op1.format());
+        compileValueToInt32(node.child1());
         break;
     }

I think it should be compileValueToInt32(node);
Comment 4 Yuqiang Xian 2011-10-14 02:49:39 PDT
(In reply to comment #3)

I have included the fix in bug #70069

> 
> I think it should be compileValueToInt32(node);
Comment 5 Yuqiang Xian 2011-10-14 02:50:29 PDT
(In reply to comment #4)

Sorry - should be bug #70096

> (In reply to comment #3)
> 
> I have included the fix in bug #70069
> 
> > 
> > I think it should be compileValueToInt32(node);