Bug 70096 - DFG JIT 32_64 - Performance fix for ResolveGlobal
Summary: DFG JIT 32_64 - Performance fix for ResolveGlobal
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-10-14 02:40 PDT by Yuqiang Xian
Modified: 2011-10-14 10:22 PDT (History)
3 users (show)

See Also:


Attachments
the patch (3.97 KB, patch)
2011-10-14 02:47 PDT, Yuqiang Xian
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Yuqiang Xian 2011-10-14 02:40:05 PDT
Check structure of global object should be a pointer comparison instead of tag and payload pair comparison. This fix improves SunSpider by 7% on Linux 32, with bitops-bitwise-and improved by 4.75X.
Comment 1 Yuqiang Xian 2011-10-14 02:47:30 PDT
Created attachment 110986 [details]
the patch

Also two trivial fixes for successful 32-bit build are included.
Comment 2 WebKit Review Bot 2011-10-14 10:22:45 PDT
Comment on attachment 110986 [details]
the patch

Clearing flags on attachment: 110986

Committed r97477: <http://trac.webkit.org/changeset/97477>
Comment 3 WebKit Review Bot 2011-10-14 10:22:49 PDT
All reviewed patches have been landed.  Closing bug.