Bug 70040 - [WebKit2][gtk] Rename WEBKIT_POLICY_ERROR_CANNOT_SHOW_URL to WEBKIT_POLICY_ERROR_CANNOT_SHOW_URI
Summary: [WebKit2][gtk] Rename WEBKIT_POLICY_ERROR_CANNOT_SHOW_URL to WEBKIT_POLICY_ER...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on: 70016
Blocks:
  Show dependency tree / graph
 
Reported: 2011-10-13 10:56 PDT by Nayan Kumar K
Modified: 2011-10-17 01:57 PDT (History)
2 users (show)

See Also:

Attachments
Rename (3.28 KB, patch)
2011-10-14 04:40 PDT, Nayan Kumar K 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Nayan Kumar K 2011-10-13 10:56:47 PDT 
Rename the enum WEBKIT_POLICY_ERROR_CANNOT_SHOW_URL (in Source/WebKit2/UIProcess/API/gtk/WebKitError.h) to WEBKIT_POLICY_ERROR_CANNOT_SHOW_URI.
Comment 1 Nayan Kumar K 2011-10-14 04:40:17 PDT 
Created attachment 110992 [details]
Rename

I have not renamed this enum in WebKit1 and in WebCore. Please let me know if it is needed.
Comment 2 WebKit Review Bot 2011-10-14 10:15:20 PDT 
Comment on attachment 110992 [details]
Rename

Rejecting attachment 110992 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2

Last 500 characters of output:
s).
patching file Source/WebKit2/ChangeLog
Hunk #1 succeeded at 1 with fuzz 3.
patching file Source/WebKit2/UIProcess/API/gtk/WebKitError.cpp
patching file Source/WebKit2/UIProcess/API/gtk/WebKitError.h
Hunk #1 FAILED at 55.
Hunk #2 succeeded at 55 (offset -9 lines).
1 out of 2 hunks FAILED -- saving rejects to file Source/WebKit2/UIProcess/API/gtk/WebKitError.h.rej

Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--reviewer', u'Martin Robinson', u'--..." exit_code: 1

Full output: http://queues.webkit.org/results/10056608
Comment 3 WebKit Review Bot 2011-10-14 13:33:42 PDT 
Comment on attachment 110992 [details]
Rename

Rejecting attachment 110992 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2

Last 500 characters of output:
s).
patching file Source/WebKit2/ChangeLog
Hunk #1 succeeded at 1 with fuzz 3.
patching file Source/WebKit2/UIProcess/API/gtk/WebKitError.cpp
patching file Source/WebKit2/UIProcess/API/gtk/WebKitError.h
Hunk #1 FAILED at 55.
Hunk #2 succeeded at 55 (offset -9 lines).
1 out of 2 hunks FAILED -- saving rejects to file Source/WebKit2/UIProcess/API/gtk/WebKitError.h.rej

Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--reviewer', u'Martin Robinson', u'--..." exit_code: 1

Full output: http://queues.webkit.org/results/10054648
Comment 4 WebKit Review Bot 2011-10-17 01:57:21 PDT 
Comment on attachment 110992 [details]
Rename

Clearing flags on attachment: 110992

Committed r97592: <http://trac.webkit.org/changeset/97592>
Comment 5 WebKit Review Bot 2011-10-17 01:57:26 PDT 
All reviewed patches have been landed.  Closing bug.