70040 – [WebKit2][gtk] Rename WEBKIT_POLICY_ERROR_CANNOT_SHOW_URL to WEBKIT_POLICY_ERROR_CANNOT_SHOW_URI

Nayan Kumar K

Reported 2011-10-13 10:56:47 PDT

Rename the enum WEBKIT_POLICY_ERROR_CANNOT_SHOW_URL (in Source/WebKit2/UIProcess/API/gtk/WebKitError.h) to WEBKIT_POLICY_ERROR_CANNOT_SHOW_URI.

Nayan Kumar K

Comment 1 2011-10-14 04:40:17 PDT

Created attachment 110992 [details] Rename I have not renamed this enum in WebKit1 and in WebCore. Please let me know if it is needed.

WebKit Review Bot

Comment 2 2011-10-14 10:15:20 PDT

Comment on attachment 110992 [details] Rename Rejecting attachment 110992 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 Last 500 characters of output: s). patching file Source/WebKit2/ChangeLog Hunk #1 succeeded at 1 with fuzz 3. patching file Source/WebKit2/UIProcess/API/gtk/WebKitError.cpp patching file Source/WebKit2/UIProcess/API/gtk/WebKitError.h Hunk #1 FAILED at 55. Hunk #2 succeeded at 55 (offset -9 lines). 1 out of 2 hunks FAILED -- saving rejects to file Source/WebKit2/UIProcess/API/gtk/WebKitError.h.rej Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--reviewer', u'Martin Robinson', u'--..." exit_code: 1 Full output: http://queues.webkit.org/results/10056608

WebKit Review Bot

Comment 3 2011-10-14 13:33:42 PDT

Comment on attachment 110992 [details] Rename Rejecting attachment 110992 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 Last 500 characters of output: s). patching file Source/WebKit2/ChangeLog Hunk #1 succeeded at 1 with fuzz 3. patching file Source/WebKit2/UIProcess/API/gtk/WebKitError.cpp patching file Source/WebKit2/UIProcess/API/gtk/WebKitError.h Hunk #1 FAILED at 55. Hunk #2 succeeded at 55 (offset -9 lines). 1 out of 2 hunks FAILED -- saving rejects to file Source/WebKit2/UIProcess/API/gtk/WebKitError.h.rej Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--reviewer', u'Martin Robinson', u'--..." exit_code: 1 Full output: http://queues.webkit.org/results/10054648

WebKit Review Bot

Comment 4 2011-10-17 01:57:21 PDT

Comment on attachment 110992 [details] Rename Clearing flags on attachment: 110992 Committed r97592: <http://trac.webkit.org/changeset/97592>

WebKit Review Bot

Comment 5 2011-10-17 01:57:26 PDT

All reviewed patches have been landed. Closing bug.

Attachments
Rename (3.28 KB, patch) 2011-10-14 04:40 PDT, Nayan Kumar K	no flags	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.