RESOLVED FIXED 70016
[WebKit2][gtk] Add documentation for WebKitPluginError and WebKitPolicyError. 
https://bugs.webkit.org/show_bug.cgi?id=70016
Summary [WebKit2][gtk] Add documentation for WebKitPluginError and WebKitPolicyError.
Nayan Kumar K
Reported 2011-10-13 04:33:04 PDT
Documentation is missing for WebKitPluginError and WebKitPolicyError
Attachments
Add missing documentation (2.62 KB, patch)
2011-10-13 04:43 PDT, Nayan Kumar K 		mrobinson: review-
DetailsFormatted DiffDiff
Add missing documentation (2.62 KB, patch)
2011-10-13 10:57 PDT, Nayan Kumar K 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Nayan Kumar K
Comment 1 2011-10-13 04:43:36 PDT
Created attachment 110826 [details] Add missing documentation
Martin Robinson
Comment 2 2011-10-13 08:32:51 PDT
Comment on attachment 110826 [details] Add missing documentation View in context: https://bugs.webkit.org/attachment.cgi?id=110826&action=review Looks good, except for one small nit. > Source/WebKit2/UIProcess/API/gtk/WebKitError.h:58 > + * @WEBKIT_POLICY_ERROR_CANNOT_SHOW_URL: Load failure due to url that can not be shown url should actually say "URI" This also suggests that we should rename WEBKIT_POLICY_ERROR_CANNOT_SHOW_URL to WEBKIT_POLICY_ERROR_CANNOT_SHOW_URI in another bug.
Nayan Kumar K
Comment 3 2011-10-13 10:57:55 PDT
Created attachment 110879 [details] Add missing documentation
Nayan Kumar K
Comment 4 2011-10-13 10:59:17 PDT
Comment on attachment 110826 [details] Add missing documentation View in context: https://bugs.webkit.org/attachment.cgi?id=110826&action=review >> Source/WebKit2/UIProcess/API/gtk/WebKitError.h:58 >> + * @WEBKIT_POLICY_ERROR_CANNOT_SHOW_URL: Load failure due to url that can not be shown > > url should actually say "URI" > > This also suggests that we should rename WEBKIT_POLICY_ERROR_CANNOT_SHOW_URL to WEBKIT_POLICY_ERROR_CANNOT_SHOW_URI in another bug. Bug https://bugs.webkit.org/show_bug.cgi?id=70040has been raised to rename this enum. I will submit the patch for this rename soon.
WebKit Review Bot
Comment 5 2011-10-14 13:57:18 PDT
Comment on attachment 110879 [details] Add missing documentation Clearing flags on attachment: 110879 Committed r97503: <http://trac.webkit.org/changeset/97503>
WebKit Review Bot
Comment 6 2011-10-14 13:57:22 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.