Documentation is missing for WebKitPluginError and WebKitPolicyError
Created attachment 110826 [details] Add missing documentation
Comment on attachment 110826 [details] Add missing documentation View in context: https://bugs.webkit.org/attachment.cgi?id=110826&action=review Looks good, except for one small nit. > Source/WebKit2/UIProcess/API/gtk/WebKitError.h:58 > + * @WEBKIT_POLICY_ERROR_CANNOT_SHOW_URL: Load failure due to url that can not be shown url should actually say "URI" This also suggests that we should rename WEBKIT_POLICY_ERROR_CANNOT_SHOW_URL to WEBKIT_POLICY_ERROR_CANNOT_SHOW_URI in another bug.
Created attachment 110879 [details] Add missing documentation
Comment on attachment 110826 [details] Add missing documentation View in context: https://bugs.webkit.org/attachment.cgi?id=110826&action=review >> Source/WebKit2/UIProcess/API/gtk/WebKitError.h:58 >> + * @WEBKIT_POLICY_ERROR_CANNOT_SHOW_URL: Load failure due to url that can not be shown > > url should actually say "URI" > > This also suggests that we should rename WEBKIT_POLICY_ERROR_CANNOT_SHOW_URL to WEBKIT_POLICY_ERROR_CANNOT_SHOW_URI in another bug. Bug https://bugs.webkit.org/show_bug.cgi?id=70040has been raised to rename this enum. I will submit the patch for this rename soon.
Comment on attachment 110879 [details] Add missing documentation Clearing flags on attachment: 110879 Committed r97503: <http://trac.webkit.org/changeset/97503>
All reviewed patches have been landed. Closing bug.