Bug summary says "Roll Chromium DEPS to r[]", e.g. see https://bugs.webkit.org/show_bug.cgi?id=69916
Created attachment 110663 [details] Patch Looks like really fetching LKGR number at this step is hard, so let's just say "to last-known good revision", as bot says on IRC.
Comment on attachment 110663 [details] Patch Please update argument_names as well. Did you run ./Tools/Scripts/test-webkitpy ? We like to add tests whenever we make a change to webkitpy.
Comment on attachment 110663 [details] Patch This patch looks correct, but I think we'll want a test. You can look in irc_command_unittest for examples. We don't need an end-to-end test here, just something simple.
Created attachment 110744 [details] Comments addressed, test added Wow, didn't expected such a rich framework here!
Attachment 110744 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Tools/ChangeLog', u'Tools/Scripts/webkitpy..." exit_code: 1 Tools/Scripts/webkitpy/tool/commands/roll_unittest.py:52: expected 2 blank lines, found 1 [pep8/E302] [5] Total errors found: 1 in 5 files If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 110745 [details] Style fixed
Adam, can you please take another look?
Comment on attachment 110745 [details] Style fixed Thanks!
Comment on attachment 110745 [details] Style fixed Clearing flags on attachment: 110745 Committed r98315: <http://trac.webkit.org/changeset/98315>
All reviewed patches have been landed. Closing bug.