Bug 69449 - last frame of a multipart response is not displayed
Summary: last frame of a multipart response is not displayed
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Tony Chang
URL:
Keywords:
Depends on:
Blocks: 69615
  Show dependency tree / graph
 
Reported: 2011-10-05 11:50 PDT by Tony Chang
Modified: 2011-10-07 15:56 PDT (History)
9 users (show)

See Also:

Attachments
Patch (9.90 KB, patch)
2011-10-05 11:55 PDT, Tony Chang 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tony Chang 2011-10-05 11:50:56 PDT 
last frame of a multipart response is not displayed
Comment 1 Tony Chang 2011-10-05 11:55:15 PDT 
Created attachment 109832 [details]
Patch
Comment 2 Tony Chang 2011-10-05 11:55:42 PDT 
This was reported http://code.google.com/p/chromium/issues/detail?id=96371 .
Comment 3 Adam Barth 2011-10-06 13:34:12 PDT 
Comment on attachment 109832 [details]
Patch

I don't fully understand multi-part, but I've talked this over with Tony and this change seems to make sense.
Comment 4 WebKit Review Bot 2011-10-06 14:05:48 PDT 
Comment on attachment 109832 [details]
Patch

Clearing flags on attachment: 109832

Committed r96856: <http://trac.webkit.org/changeset/96856>
Comment 5 WebKit Review Bot 2011-10-06 14:05:53 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 6 Csaba Osztrogonác 2011-10-07 01:21:52 PDT 
This new test fails on the GTK and on the Qt bot:

http://build.webkit.org/results/GTK%20Linux%2032-bit%20Release/r96911%20%2818051%29/http/tests/multipart/load-last-non-html-frame-pretty-diff.html

It might be similar to https://bugs.webkit.org/show_bug.cgi?id=68979. I think there is a serious problem with multipart tests near Qt and GTK port
Comment 8 Tony Chang 2011-10-07 13:28:19 PDT 
(In reply to comment #7)
> The test added by this patch has been crashing on Snow Leopard test bots:
> http://build.webkit.org/results/SnowLeopard%20Intel%20Release%20(Tests)/r96941%20(33722)/results.html
> 
> http://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=http%2Ftests%2Fmultipart%2Fload-last-non-html-frame.php&group=%40ToT%20-%20webkit.org&showExpectations=true

It appears to be passing now.  Do we know what changed?  Maybe the bots were sick?
Comment 9 Ryosuke Niwa 2011-10-07 13:46:21 PDT 
(In reply to comment #8)
> (In reply to comment #7)
> > The test added by this patch has been crashing on Snow Leopard test bots:
> > http://build.webkit.org/results/SnowLeopard%20Intel%20Release%20(Tests)/r96941%20(33722)/results.html
> > 
> > http://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=http%2Ftests%2Fmultipart%2Fload-last-non-html-frame.php&group=%40ToT%20-%20webkit.org&showExpectations=true
> 
> It appears to be passing now.  Do we know what changed?  Maybe the bots were sick?

That's a bug in the flakiness dashboard. nrwt has beeen exiting early due to kling's patch I just rolled out.
Comment 10 Tony Chang 2011-10-07 15:56:56 PDT 
Fix for mac crash in bug 69675.