Bug 69449 – last frame of a multipart response is not displayed

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Tony Chang]

last frame of a multipart response is not displayed

[Tony Chang]

Created attachment 109832 [details]
Patch

[Tony Chang]

This was reported http://code.google.com/p/chromium/issues/detail?id=96371 .

[Adam Barth]

Comment on attachment 109832 [details]
Patch

I don't fully understand multi-part, but I've talked this over with Tony and this change seems to make sense.

[WebKit Review Bot]

Comment on attachment 109832 [details]
Patch

Clearing flags on attachment: 109832

Committed r96856: <http://trac.webkit.org/changeset/96856>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.

[Csaba Osztrogonác]

This new test fails on the GTK and on the Qt bot:

http://build.webkit.org/results/GTK%20Linux%2032-bit%20Release/r96911%20%2818051%29/http/tests/multipart/load-last-non-html-frame-pretty-diff.html

It might be similar to https://bugs.webkit.org/show_bug.cgi?id=68979. I think there is a serious problem with multipart tests near Qt and GTK port

[Ryosuke Niwa]

The test added by this patch has been crashing on Snow Leopard test bots:
http://build.webkit.org/results/SnowLeopard%20Intel%20Release%20(Tests)/r96941%20(33722)/results.html

http://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=http%2Ftests%2Fmultipart%2Fload-last-non-html-frame.php&group=%40ToT%20-%20webkit.org&showExpectations=true

[Tony Chang]

(In reply to comment #7)
> The test added by this patch has been crashing on Snow Leopard test bots:
> http://build.webkit.org/results/SnowLeopard%20Intel%20Release%20(Tests)/r96941%20(33722)/results.html
> 
> http://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=http%2Ftests%2Fmultipart%2Fload-last-non-html-frame.php&group=%40ToT%20-%20webkit.org&showExpectations=true

It appears to be passing now.  Do we know what changed?  Maybe the bots were sick?

[Ryosuke Niwa]

(In reply to comment #8)
> (In reply to comment #7)
> > The test added by this patch has been crashing on Snow Leopard test bots:
> > http://build.webkit.org/results/SnowLeopard%20Intel%20Release%20(Tests)/r96941%20(33722)/results.html
> > 
> > http://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=http%2Ftests%2Fmultipart%2Fload-last-non-html-frame.php&group=%40ToT%20-%20webkit.org&showExpectations=true
> 
> It appears to be passing now.  Do we know what changed?  Maybe the bots were sick?

That's a bug in the flakiness dashboard. nrwt has beeen exiting early due to kling's patch I just rolled out.

[Tony Chang]

Fix for mac crash in bug 69675.