WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED DUPLICATE of
bug 42688
69397
Focus rings are missing in WebKitTestRunner snapshots
https://bugs.webkit.org/show_bug.cgi?id=69397
Summary
Focus rings are missing in WebKitTestRunner snapshots
Simon Fraser (smfr)
Reported
2011-10-04 21:05:25 PDT
In WebKitTestRunner pixel results, form controls don't look highlighted. They have the appearance that they have in background windows. Also, focus rings don't show up, and the caret is disabled.
Attachments
Add attachment
proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1
2011-10-04 21:06:02 PDT
<
rdar://problem/10235607
>
Simon Fraser (smfr)
Comment 2
2011-10-05 17:23:53 PDT
Actually form controls look OK, but just different in Lion. Focus rings are still missing though.
Simon Fraser (smfr)
Comment 3
2011-10-05 18:26:06 PDT
DRT/WK1 have some smarts here that we may need to replicate: in - (void)webView:(WebView *)sender didCommitLoadForFrame:(WebFrame *)frame: gLayoutTestController->setWindowIsKey(true); NSView *documentView = [[mainFrame frameView] documentView]; [[[mainFrame webView] window] makeFirstResponder:documentView]; void LayoutTestController::setWindowIsKey(bool windowIsKey) { m_windowIsKey = windowIsKey; [[mainFrame webView] _updateActiveState]; } WebView: - (void)_updateActiveState { if (_private && _private->page) _private->page->focusController()->setActive([[self window] isKeyWindow]); }
Simon Fraser (smfr)
Comment 4
2011-10-06 12:10:36 PDT
*** This bug has been marked as a duplicate of
bug 42688
***
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug