Bug 69397 - Focus rings are missing in WebKitTestRunner snapshots
Summary: Focus rings are missing in WebKitTestRunner snapshots
Status: RESOLVED DUPLICATE of bug 42688
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Simon Fraser (smfr)
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2011-10-04 21:05 PDT by Simon Fraser (smfr)
Modified: 2011-10-06 12:10 PDT (History)
4 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Simon Fraser (smfr) 2011-10-04 21:05:25 PDT 
In WebKitTestRunner pixel results, form controls don't look highlighted. They have the appearance that they have in background windows. Also, focus rings don't show up, and the caret is disabled.
Comment 1 Radar WebKit Bug Importer 2011-10-04 21:06:02 PDT 
<rdar://problem/10235607>
Comment 2 Simon Fraser (smfr) 2011-10-05 17:23:53 PDT 
Actually form controls look OK, but just different in Lion. Focus rings are still missing though.
Comment 3 Simon Fraser (smfr) 2011-10-05 18:26:06 PDT 
DRT/WK1 have some smarts here that we may need to replicate:

in - (void)webView:(WebView *)sender didCommitLoadForFrame:(WebFrame *)frame:
   
    gLayoutTestController->setWindowIsKey(true);
    NSView *documentView = [[mainFrame frameView] documentView];
    [[[mainFrame webView] window] makeFirstResponder:documentView];


void LayoutTestController::setWindowIsKey(bool windowIsKey)
{
    m_windowIsKey = windowIsKey;
    [[mainFrame webView] _updateActiveState];
}

WebView:
- (void)_updateActiveState
{
    if (_private && _private->page)
        _private->page->focusController()->setActive([[self window] isKeyWindow]);
}
Comment 4 Simon Fraser (smfr) 2011-10-06 12:10:36 PDT 

*** This bug has been marked as a duplicate of bug 42688 ***