Bug 42688 - WebKitTestRunner needs layoutTestController.setWindowIsKey
Summary: WebKitTestRunner needs layoutTestController.setWindowIsKey
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Simon Fraser (smfr)
URL:
Keywords: InRadar
: 69397 (view as bug list)
Depends on:
Blocks:
 
Reported: 2010-07-20 15:14 PDT by Sam Weinig
Modified: 2011-10-10 14:01 PDT (History)
4 users (show)

See Also:

Attachments
Patch (24.79 KB, patch)
2011-10-06 12:20 PDT, Simon Fraser (smfr) 		no flags Details | Formatted Diff | Diff
Patch which fixes Windows (24.79 KB, patch)
2011-10-06 13:53 PDT, Simon Fraser (smfr) 		no flags Details | Formatted Diff | Diff
Patch (21.91 KB, patch)
2011-10-10 13:43 PDT, Simon Fraser (smfr) 		andersca: review+
Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Sam Weinig 2010-07-20 15:14:32 PDT 
WebKitTestRunner needs layoutTestController.setWindowIsKey
Comment 1 Sam Weinig 2010-07-20 15:32:00 PDT 
<rdar://problem/8213853>
Comment 2 Simon Fraser (smfr) 2011-10-06 12:10:36 PDT 
*** Bug 69397 has been marked as a duplicate of this bug. ***
Comment 3 Simon Fraser (smfr) 2011-10-06 12:20:44 PDT 
Created attachment 109992 [details]
Patch
Comment 4 Simon Fraser (smfr) 2011-10-06 13:53:59 PDT 
Created attachment 110012 [details]
Patch which fixes Windows
Comment 5 Gustavo Noronha (kov) 2011-10-06 15:48:13 PDT 
Comment on attachment 110012 [details]
Patch which fixes Windows

Attachment 110012 [details] did not pass gtk-ews (gtk):
Output: http://queues.webkit.org/results/9998003
Comment 6 Darin Adler 2011-10-06 16:33:09 PDT 
Comment on attachment 110012 [details]
Patch which fixes Windows

View in context: https://bugs.webkit.org/attachment.cgi?id=110012&action=review

> Tools/ChangeLog:9
> +        Since this does window-level stuff, it now has to be asynchronous, so add

I don’t understand that. Can’t it be a synchronous call from the web process to the UI process?
Comment 7 Simon Fraser (smfr) 2011-10-06 16:47:10 PDT 
(In reply to comment #6)
> (From update of attachment 110012 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=110012&action=review
> 
> > Tools/ChangeLog:9
> > +        Since this does window-level stuff, it now has to be asynchronous, so add
> 
> I don’t understand that. Can’t it be a synchronous call from the web process to the UI process?

It could, and I guess we don't care for testing-only methods. I was following Joh's lead on the addChromeInputField stuff.
Comment 8 Simon Fraser (smfr) 2011-10-10 13:43:45 PDT 
Created attachment 110395 [details]
Patch
Comment 9 Simon Fraser (smfr) 2011-10-10 14:01:09 PDT 
http://trac.webkit.org/changeset/97081