WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
69360
new-run-webkit-tests appends "/Debug" or "/Release" to $WEBKITOUTPUTDIR
https://bugs.webkit.org/show_bug.cgi?id=69360
Summary
new-run-webkit-tests appends "/Debug" or "/Release" to $WEBKITOUTPUTDIR
Raphael Kubo da Costa (:rakuco)
Reported
2011-10-04 12:02:09 PDT
I have a custom build directory location, namely $webkitroot/WebKitBuild/Debug-{qt,efl,gtk}, so I export the $WEBKITOUTPUTDIR environment variable to that location. With old-run-webkit-tests, I can pass "--efl" and it will launch $WEBKITOUTPUTDIR/Programs/DumpRenderTree. However, if I pass "--product=efl --debug" to new-run-webkit-tests, it will call "webkit-build-directory --configuration --debug", which will return $WEBKITOUTPUTDIR/Debug. This, in turn, means n-r-w-t will try to launch $WEBKITOUTPUTDIR/Debug/Programs/DumpRenderTree, which does not exist. The problems seems to come from the fact that webkit-build-directory does not pass "--efl" or "--gtk" to webkitdirs.pm, so the usesPerConfigurationBuildDirectory function always returns false.
Attachments
Patch
(4.17 KB, patch)
2012-06-18 14:39 PDT
,
Dirk Pranke
no flags
Details
Formatted Diff
Diff
add unit test
(6.08 KB, patch)
2012-06-19 11:36 PDT
,
Dirk Pranke
eric
: review+
Details
Formatted Diff
Diff
Show Obsolete
(1)
View All
Add attachment
proposed patch, testcase, etc.
Eric Seidel (no email)
Comment 1
2011-10-04 12:04:04 PDT
I'm confused. You're expecting WEBKITOUTPUTDIR to be used directly without any /Debug suffix?
Raphael Kubo da Costa (:rakuco)
Comment 2
2011-10-04 12:11:22 PDT
Yes, just like o-w-r-t does -- in fact, I'd like to have from webkitdirs.pm's determineConfigurationProductDir behave the same way it does with o-r-w-t when usesPerConfigurationBuildDirectory returns true.
Dirk Pranke
Comment 3
2012-06-18 14:16:09 PDT
it looks like after
http://trac.webkit.org/changeset/103234
this is only true for gtk and apple win.
Dirk Pranke
Comment 4
2012-06-18 14:39:23 PDT
Created
attachment 148174
[details]
Patch
Eric Seidel (no email)
Comment 5
2012-06-19 09:01:38 PDT
Comment on
attachment 148174
[details]
Patch I don't understand what this does. It seems like it woule be possible to test that Config with a MockExecutive makes the right call.. so we should test that, no?
Dirk Pranke
Comment 6
2012-06-19 09:19:18 PDT
(In reply to
comment #5
)
> (From update of
attachment 148174
[details]
) > I don't understand what this does. It seems like it woule be possible to test that Config with a MockExecutive makes the right call.. so we should test that, no?
The change makes sure --gtk is passed to webkit-build-directory. In webkit-build-directory, if --gtk is passed, then it returns $WEBKITOUTPUTDIR instead of $WEBKITOUTPUTDIR/$configuration . I can add the mock test as you say. I was reluctant to add a test that actually verified that webkit-build-directory was doing something different for gtk specifically.
Dirk Pranke
Comment 7
2012-06-19 11:36:23 PDT
Created
attachment 148373
[details]
add unit test
Eric Seidel (no email)
Comment 8
2012-06-20 14:14:51 PDT
Comment on
attachment 148373
[details]
add unit test OK.
Dirk Pranke
Comment 9
2012-06-20 14:22:48 PDT
Committed
r120863
: <
http://trac.webkit.org/changeset/120863
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug