Bug 69352 - Add run-time enabled flag for <track>
Summary: Add run-time enabled flag for <track>
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Anna Cavender
URL:
Keywords:
Depends on:
Blocks: 43668
  Show dependency tree / graph
 
Reported: 2011-10-04 10:42 PDT by Anna Cavender
Modified: 2011-10-05 14:04 PDT (History)
9 users (show)

See Also:

Attachments
Patch (7.59 KB, patch)
2011-10-04 11:05 PDT, Anna Cavender 		no flags Details | Formatted Diff | Diff
gtk snafu fixed (7.51 KB, patch)
2011-10-04 17:33 PDT, Anna Cavender 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Anna Cavender 2011-10-04 10:42:12 PDT 
Runtime-enabling <track> involves enabling/disabling entire interfaces/classes (e.g. HTMLTrackElement, TextTrack, TextTrackCue, etc.) not just individual class attributes.  Therefore, this change will modify the CodeGenerator to accept the EnabledAtRuntime idl attribute for interfaces.
Comment 1 Anna Cavender 2011-10-04 11:05:17 PDT 
Created attachment 109651 [details]
Patch
Comment 2 Adam Barth 2011-10-04 11:34:48 PDT 
Comment on attachment 109651 [details]
Patch

Looks great.
Comment 3 Eric Seidel (no email) 2011-10-04 11:35:28 PDT 
Don't we test runtime features using layoutTestController additions?  We certainly can test some preferences that way, but I'm not sure if there is precedent for testing v8 runtime features that way.
Comment 4 Adam Barth 2011-10-04 11:37:53 PDT 
Presumably we'll get that test coverage when we test <track> itself.
Comment 5 Collabora GTK+ EWS bot 2011-10-04 16:55:21 PDT 
Comment on attachment 109651 [details]
Patch

Attachment 109651 [details] did not pass gtk-ews (gtk):
Output: http://queues.webkit.org/results/9944567
Comment 6 Anna Cavender 2011-10-04 17:33:02 PDT 
Created attachment 109722 [details]
gtk snafu fixed
Comment 7 WebKit Review Bot 2011-10-05 11:07:39 PDT 
Comment on attachment 109722 [details]
gtk snafu fixed

Clearing flags on attachment: 109722

Committed r96727: <http://trac.webkit.org/changeset/96727>
Comment 8 WebKit Review Bot 2011-10-05 11:07:44 PDT 
All reviewed patches have been landed.  Closing bug.