RESOLVED FIXED 69280
[WinCairo] Support a wincairo Skipped File
https://bugs.webkit.org/show_bug.cgi?id=69280
Summary [WinCairo] Support a wincairo Skipped File
Brent Fulgham
Reported 2011-10-03 12:21:35 PDT
Update the testing infrastructure to support the WinCairo port. This consists of: 1. Teaching "old-run-webkit-tests" to recognize when it is being asked to test a WinCairo build. 2. Add a "platform/wincairo" directory and a "Skipped" list. 3. Populate the "Skipped" list with the current set of failing WinCairo tests so that the build bot does not turn red when we activate tests.
Attachments
Patch (300.23 KB, patch)
2011-10-04 14:50 PDT, Brent Fulgham
no flags
Create a Skiplist for WinCairo. (303.42 KB, patch)
2011-10-04 19:59 PDT, Brent Fulgham
aroben: review+
Update old-build-webkit-tests to know about wincairo (2.47 KB, patch)
2011-10-04 20:04 PDT, Brent Fulgham
aroben: review+
Brent Fulgham
Comment 1 2011-10-04 09:25:40 PDT
This first patch simply adds a 'wincairo' platform directory to the LayoutTests/platform tree, and a new Skipped file that instructs the test infrastructure to ignore all tests that currently fail when running the WinCairo build.
Brent Fulgham
Comment 2 2011-10-04 14:50:38 PDT
Brent Fulgham
Comment 3 2011-10-04 19:59:10 PDT
Created attachment 109733 [details] Create a Skiplist for WinCairo.
Brent Fulgham
Comment 4 2011-10-04 20:04:59 PDT
Created attachment 109735 [details] Update old-build-webkit-tests to know about wincairo
Adam Roben (:aroben)
Comment 5 2011-10-05 12:30:08 PDT
Comment on attachment 109735 [details] Update old-build-webkit-tests to know about wincairo View in context: https://bugs.webkit.org/attachment.cgi?id=109735&action=review > Tools/Scripts/old-run-webkit-tests:2479 > - > + Might as well undo this. > Tools/Scripts/webkitdirs.pm:238 > if ($configuration && isWinCairo()) { > - $configuration .= "_Cairo_CFLite"; > + unless ($configuration =~ /_Cairo_CFLite$/) { > + $configuration .= "_Cairo_CFLite"; > + } > } Was this always buggy? Why hadn't we run into it before?
Adam Roben (:aroben)
Comment 6 2011-10-05 12:31:12 PDT
Comment on attachment 109733 [details] Create a Skiplist for WinCairo. You can list directories in the Skipped file to skip all tests in that directory and its subdirectories. Maybe that would be a simpler way to start out? (And it would guard you against new tests being added in a directory that you haven't un-skipped yet.)
Brent Fulgham
Comment 7 2011-10-05 13:12:03 PDT
Comment on attachment 109735 [details] Update old-build-webkit-tests to know about wincairo View in context: https://bugs.webkit.org/attachment.cgi?id=109735&action=review >> Tools/Scripts/webkitdirs.pm:238 >> } > > Was this always buggy? Why hadn't we run into it before? I don't think the code had been executed previously. I ran across this when passing the command line "--wincairo" argument to the test tool. I think an earlier step generates the configuration name based on the build (which causes the _Cairo_CFLite to be affixed to the end). Then, the test harness processes the name again and added a second application of the suffix. There is probably a cleaner way to address this...
Brent Fulgham
Comment 8 2011-10-05 13:35:38 PDT
Note You need to log in before you can comment on or make changes to this bug.