Bug 69272 - [WinCairo] Switch to Release builds and activate tests on buildbot
Summary: [WinCairo] Switch to Release builds and activate tests on buildbot
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC All
: P2 Normal
Assignee: Brent Fulgham
URL:
Keywords:
Depends on: 69280
Blocks:
  Show dependency treegraph
 
Reported: 2011-10-03 11:27 PDT by Brent Fulgham
Modified: 2011-10-06 15:42 PDT (History)
1 user (show)

See Also:


Attachments
Patch (1.58 KB, patch)
2011-10-03 11:31 PDT, Brent Fulgham
no flags Details | Formatted Diff | Diff
Patch (1.57 KB, patch)
2011-10-03 11:35 PDT, Brent Fulgham
no flags Details | Formatted Diff | Diff
Patch (3.34 KB, patch)
2011-10-04 20:00 PDT, Brent Fulgham
no flags Details | Formatted Diff | Diff
Patch (1.59 KB, patch)
2011-10-05 17:31 PDT, Brent Fulgham
no flags Details | Formatted Diff | Diff
Patch (1.92 KB, patch)
2011-10-06 15:30 PDT, Brent Fulgham
rniwa: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Brent Fulgham 2011-10-03 11:27:39 PDT
Change the WinCairo build bot configuration to build the Release target, and start running tests.
Comment 1 Brent Fulgham 2011-10-03 11:31:15 PDT
Created attachment 109500 [details]
Patch
Comment 2 Adam Roben (:aroben) 2011-10-03 11:32:47 PDT
Comment on attachment 109500 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=109500&action=review

Since we expect this to turn the bot red, perhaps we should also remove the bot from the set of core builders?

> Tools/BuildSlaveSupport/build.webkit.org-config/config.json:257
> +                      "name": "WinCairo Release (Build)", "type": "BuildAndTest", "builddir": "win-cairo-release",

The "(Build)" suffix is typically only used for build-only bots. So I think you should remove it.
Comment 3 Brent Fulgham 2011-10-03 11:35:11 PDT
Created attachment 109501 [details]
Patch
Comment 4 Brent Fulgham 2011-10-04 20:00:29 PDT
Created attachment 109734 [details]
Patch
Comment 5 Brent Fulgham 2011-10-05 17:31:51 PDT
Created attachment 109889 [details]
Patch
Comment 6 Brent Fulgham 2011-10-05 17:35:29 PDT
Landed in http://trac.webkit.org/changeset/96773.
Comment 7 Brent Fulgham 2011-10-06 15:28:10 PDT
Reopen to correct bug in config file:

aroben: bfulgham-afk: AssertionError: <buildbot.schedulers.basic.AnyBranchScheduler instance at 0x102239a70> uses unknown builder WinCairo Debug (Build)
[8:55pm] aroben: bfulgham-afk: I think your patch is buggy
[8:55pm] rakuco: smfr: hey. do you have plans to commit the parts of your patch in bug 68134 which you didn't commit (namely the ScrollbarTheme::theme() part)? I've been running a slightly modified version of the code locally for EFL's DRT and it's been working fine
[8:55pm] aroben: bfulgham-afk: looks like config.json still contains an instance of "WinCairo Debug (Build)"
Comment 8 Brent Fulgham 2011-10-06 15:30:08 PDT
Created attachment 110044 [details]
Patch
Comment 9 Brent Fulgham 2011-10-06 15:42:45 PDT
Committed r96865: <http://trac.webkit.org/changeset/96865>