WebKit Bugzilla
New
Browse
Search+
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
69240
[Chromium] 10% intl1 PLT regression Sept 28
https://bugs.webkit.org/show_bug.cgi?id=69240
Summary
[Chromium] 10% intl1 PLT regression Sept 28
Adam Barth
Reported
2011-10-02 22:42:17 PDT
http://build.chromium.org/f/chromium/perf/xp-release-dual-core/intl1/report.html?history=130&rev=103677
This appears to be caused by this Skia roll r2351:r2358:
http://src.chromium.org/viewvc/chrome?view=rev&revision=103204
Attachments
Add attachment
proposed patch, testcase, etc.
Adam Barth
Comment 1
2011-10-02 22:47:48 PDT
http://code.google.com/p/skia/source/list?num=7&start=2358
Adam Barth
Comment 2
2011-10-02 22:48:41 PDT
Maybe this change
http://code.google.com/p/skia/source/detail?r=2358
?
Mike Reed
Comment 3
2011-10-03 05:52:16 PDT
This is in process of being fixed/reversed.
Adam Barth
Comment 4
2011-10-03 08:46:58 PDT
> This is in process of being fixed/reversed.
I'm concerned that
Bug 67876
has been unresolved for upwards of a month. It's important that we not carry these regression in the tree because they mask other regressions. Do you have an estimate for when this issue will be resolved?
Mike Reed
Comment 5
2011-10-03 08:56:31 PDT
Should be fixed in latest skia DEPS roll.
Adam Barth
Comment 6
2011-10-03 09:06:33 PDT
> Should be fixed in latest skia DEPS roll.
Thanks Mike. It looks on this graph that we've gotten most (if not all) of the performance back:
http://build.chromium.org/f/chromium/perf/xp-release-dual-core/intl1/report.html?history=150&rev=103710
This improvement appears to have been cause by rolling Skia:
http://src.chromium.org/viewvc/chrome?view=rev&revision=103704
Just to confirm before closing this bug: That improvement is the fix for the Sept 28 regression and not for the regression we're tracking in
Bug 67876
? (They are of a similar magnitude, which makes it hard for me to tell just from the graph.)
Mike Reed
Comment 7
2011-10-03 09:10:15 PDT
I think so. The recent regression was definitely due to 2358, which was (effectively) reverted.
Adam Barth
Comment 8
2011-10-03 09:12:30 PDT
Thanks for the quick response.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug