Bug 69240 - [Chromium] 10% intl1 PLT regression Sept 28
Summary: [Chromium] 10% intl1 PLT regression Sept 28
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Page Loading (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks: 69237
  Show dependency treegraph
 
Reported: 2011-10-02 22:42 PDT by Adam Barth
Modified: 2011-10-03 09:12 PDT (History)
2 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Comment 2 Adam Barth 2011-10-02 22:48:41 PDT
Maybe this change http://code.google.com/p/skia/source/detail?r=2358 ?
Comment 3 Mike Reed 2011-10-03 05:52:16 PDT
This is in process of being fixed/reversed.
Comment 4 Adam Barth 2011-10-03 08:46:58 PDT
> This is in process of being fixed/reversed.

I'm concerned that Bug 67876 has been unresolved for upwards of a month.  It's important that we not carry these regression in the tree because they mask other regressions.  Do you have an estimate for when this issue will be resolved?
Comment 5 Mike Reed 2011-10-03 08:56:31 PDT
Should be fixed in latest skia DEPS roll.
Comment 6 Adam Barth 2011-10-03 09:06:33 PDT
> Should be fixed in latest skia DEPS roll.

Thanks Mike.  It looks on this graph that we've gotten most (if not all) of the performance back:

http://build.chromium.org/f/chromium/perf/xp-release-dual-core/intl1/report.html?history=150&rev=103710

This improvement appears to have been cause by rolling Skia:

http://src.chromium.org/viewvc/chrome?view=rev&revision=103704

Just to confirm before closing this bug: That improvement is the fix for the Sept 28 regression and not for the regression we're tracking in Bug 67876 ?  (They are of a similar magnitude, which makes it hard for me to tell just from the graph.)
Comment 7 Mike Reed 2011-10-03 09:10:15 PDT
I think so. The recent regression was definitely due to 2358, which was (effectively) reverted.
Comment 8 Adam Barth 2011-10-03 09:12:30 PDT
Thanks for the quick response.