Bug 67876 – [Chromium Win] 10% PLT regression r94589

• Status: RESOLVED
• Resolution: WONTFIX
• Component: WebCore Misc.

[Adam Barth]

Something in this range:

http://trac.webkit.org/log/trunk?rev=94653&stop_rev=94560&verbose=on

Appears to have caused a 10% PLT regression:

http://build.chromium.org/f/chromium/perf/xp-release-dual-core/intl1/report.html?history=150&rev=100517

Notice the first spike when those revs were rolled into Chromium in Chromium@99936 and then the sustained rise after they were rolling in again in Chromium@100029.

[Adam Barth]

I don't know whether this manifests on ports besides Chromium or on other test suites besides intl1.

[Stephanie Lewis]

i'll check our tests on Monday.

[Ilya Tikhonovsky]

(In reply to comment #2)
> i'll check our tests on Monday.

I've made some bisecting steps.

94619 - bad
94588 - good

[Ilya Tikhonovsky]

(In reply to comment #3)
> (In reply to comment #2)
> > i'll check our tests on Monday.
> 
> I've made some bisecting steps.
> 
> 94619 - bad
> 94588 - good

it is 94589


Author: [e-mail] <[e-mail]@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Date:   Tue Sep 6 19:21:52 2011 +0000

    [skia] never draw with GDI, so that all text can be gpu-accelerated
    https://bugs.webkit.org/show_bug.cgi?id=65203
    
    Reviewed by Kenneth Russell.
    
    Source/WebCore:
    
    * platform/graphics/chromium/FontChromiumWin.cpp:
    (WebCore::TransparencyAwareFontPainter::TransparencyAwareFontPainter::TransparencyAwareFontPainter):
    (WebCore::TransparencyAwareFontPainter::TransparencyAwareGlyphPainter::TransparencyAwareGlyphPainter):
    (WebCore::TransparencyAwareFontPainter::TransparencyAwareGlyphPainter::drawGlyphs):
    (WebCore::TransparencyAwareFontPainter::TransparencyAwareUniscribePainter::TransparencyAwareUniscribePainter):
    (WebCore::drawGlyphsWin):
    (WebCore::Font::drawComplexText):
    * platform/graphics/chromium/UniscribeHelper.cpp:
    (WebCore::UniscribeHelper::draw):
    * platform/graphics/skia/PlatformContextSkia.cpp:
    * platform/graphics/skia/PlatformContextSkia.h:
    * platform/graphics/skia/SkiaFontWin.cpp:
    (WebCore::skiaDrawText):
    * platform/graphics/skia/SkiaFontWin.h:
    
    LayoutTests:
    
    * platform/chromium/test_expectations.txt:

[Adam Barth]

Would it make sense to roll out that patch while we investigate?  We don't want this perf regression to hide other problems.

[Adam Barth]

(Just so others don't spend too long looking, this patch is after the M15 branch point.)

[Jungshik Shin]

http://crbug.com/95748

[Adam Barth]

What's the current status of this issue?  What the patch rolled out?  Was the performance regression fixed?

[Adam Barth]

*** Bug 69239 has been marked as a duplicate of this bug. ***