Bug 69182 – BiquadFilterNode .type attribute is not handled correctly

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Chris Rogers]

BiquadFilterNode .type attribute is not handled correctly

[Chris Rogers]

Created attachment 109375 [details]
Patch

[Kenneth Russell]

Comment on attachment 109375 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=109375&action=review

Looks fine overall; couple of comments. r=me

> LayoutTests/webaudio/biquadfilternode-basic.html:29
> +    // FIXME: we need to expose the actual filter type constants in the IDL

Have you already filed a bug about this?

> LayoutTests/webaudio/biquadfilternode-basic.html:38
> +    for (var i = 0; i <= 7; ++i) {

FIXME for the magic constant 7.

> Source/WebCore/platform/audio/AudioDSPKernelProcessor.cpp:61
> +    m_hasJustReset = true;

Is this fix really related or should it be a separate change?

[Chris Rogers]

Committed r96525: <http://trac.webkit.org/changeset/96525>

[Chris Rogers]

Comment on attachment 109375 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=109375&action=review

>> LayoutTests/webaudio/biquadfilternode-basic.html:29
>> +    // FIXME: we need to expose the actual filter type constants in the IDL
> 
> Have you already filed a bug about this?

Just filed:
https://bugs.webkit.org/show_bug.cgi?id=69276

>> LayoutTests/webaudio/biquadfilternode-basic.html:38
>> +    for (var i = 0; i <= 7; ++i) {
> 
> FIXME for the magic constant 7.

added FIXME here

>> Source/WebCore/platform/audio/AudioDSPKernelProcessor.cpp:61
>> +    m_hasJustReset = true;
> 
> Is this fix really related or should it be a separate change?

It's related since, it's required when changing filter types.  The filter state needs to be reset...

[Boris Smus]

Thanks for fixing. Verified in Canary.