Bug 69276 - BiquadFilterNode should explicitly expose filter type constants in IDL
Summary: BiquadFilterNode should explicitly expose filter type constants in IDL
Status: RESOLVED INVALID
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Audio (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Rogers
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-10-03 12:03 PDT by Chris Rogers
Modified: 2012-03-15 15:04 PDT (History)
2 users (show)

See Also:

Attachments
Possible implementation (2.25 KB, patch)
2011-11-18 13:31 PST, Raymond Toy 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Rogers 2011-10-03 12:03:55 PDT 
In the Web Audio API specification, the BiquadFilterNode interface defines filter type constants:
https://dvcs.w3.org/hg/audio/raw-file/tip/webaudio/specification.html#BiquadFilterNode-section

These need to be exposed to JavaScript in the IDL.
Comment 1 Raymond Toy 2011-11-18 13:31:24 PST 
Created attachment 115861 [details]
Possible implementation

A possible patch for BiquadFilterNode to expose the filter constants in IDL.  This was tested on chromium and it works.  Did not test with Safari.
Comment 2 Raymond Toy 2011-11-18 15:34:43 PST 
That patch isn't needed.  If filter is a BiquadFilterNode, then filter.LOWPASS is 0, filter.HIGHPASS is 1, and so on.
Comment 3 Chris Rogers 2012-03-15 15:04:45 PDT 
filter constants are already defined - closing