Bug 69023 – Remove direct reads to m_firstNodeInserted and m_lastLeafInserted in ReplaceSelectionCommand

• Status: RESOLVED
• Resolution: FIXED
• Component: HTML Editing

[Ryosuke Niwa]

To resolve the bug 68874, we need to encapsulate all access to m_firstNodeInserted and m_lastLeafInserted except updates.

[Ryosuke Niwa]

Created attachment 109066 [details]
Patch

[Ryosuke Niwa]

Any reviewers?

[Enrica Casucci]

Comment on attachment 109066 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=109066&action=review

Looks good to me.

> Source/WebCore/editing/ReplaceSelectionCommand.cpp:1226
> +        }

I know the original code was already like this, but it would be nice to have methods to update m_firstNodeInserted and m_lastLeafInserted in a consistent way. It is a bit unclear when reading this code that, in the case of the trailing space there is no explicit update of m_lastLeafInserted, but there is an explicit updated of m_firstNodeInserted in case of the leading space. Only reading the comment above helps you understand.

[Ryosuke Niwa]

(In reply to comment #3)
> (From update of attachment 109066 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=109066&action=review
> 
> Looks good to me.
> 
> > Source/WebCore/editing/ReplaceSelectionCommand.cpp:1226
> > +        }
> 
> I know the original code was already like this, but it would be nice to have methods to update m_firstNodeInserted and m_lastLeafInserted in a consistent way. It is a bit unclear when reading this code that, in the case of the trailing space there is no explicit update of m_lastLeafInserted, but there is an explicit updated of m_firstNodeInserted in case of the leading space. Only reading the comment above helps you understand.

Right. The next patch should be able to eliminate all of that.

[WebKit Review Bot]

Comment on attachment 109066 [details]
Patch

Clearing flags on attachment: 109066

Committed r96353: <http://trac.webkit.org/changeset/96353>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.