Bug 68874 - Replace m_firstNodeInserted and m_lastLeafInserted in ReplaceSelectionCommand by positions
Summary: Replace m_firstNodeInserted and m_lastLeafInserted in ReplaceSelectionCommand...
Alias: None
Product: WebKit
Classification: Unclassified
Component: HTML Editing (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ryosuke Niwa
Depends on: 68866 68875 68939 69023 69153
Blocks: 45784
  Show dependency treegraph
Reported: 2011-09-27 00:23 PDT by Ryosuke Niwa
Modified: 2011-10-03 16:04 PDT (History)
10 users (show)

See Also:

Patch (21.24 KB, patch)
2011-09-30 14:32 PDT, Ryosuke Niwa
no flags Details | Formatted Diff | Diff
Patch (21.26 KB, patch)
2011-09-30 14:34 PDT, Ryosuke Niwa
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Ryosuke Niwa 2011-09-27 00:23:51 PDT
As mentioned in several FIXMEs in ReplaceSelectionCommand, m_firstNodeInserted and m_lastLeafInserted should be replaced by real positions.
Comment 1 Ryosuke Niwa 2011-09-30 14:32:36 PDT
Created attachment 109349 [details]
Comment 2 Ryosuke Niwa 2011-09-30 14:34:41 PDT
Created attachment 109350 [details]
Comment 3 WebKit Review Bot 2011-09-30 14:35:56 PDT
Attachment 109349 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1

Source/WebCore/ChangeLog:20:  Line contains tab character.  [whitespace/tab] [5]
Source/WebCore/ChangeLog:21:  Line contains tab character.  [whitespace/tab] [5]
Total errors found: 2 in 5 files

If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 4 Ryosuke Niwa 2011-09-30 14:36:01 PDT
Comment on attachment 109350 [details]

View in context: https://bugs.webkit.org/attachment.cgi?id=109350&action=review

> Source/WebCore/editing/ReplaceSelectionCommand.cpp:1001
> +    // Setup m_startOfInsertedContent and m_endOfInsertedContent. This should be the last two lines of code that access insertedNodes.

We can do a follow up patch that puts the entire section that uses insertedNodes in a block to enforce this.
Comment 5 Ryosuke Niwa 2011-10-03 14:38:48 PDT
Any reviewers?
Comment 6 Enrica Casucci 2011-10-03 15:53:14 PDT
Comment on attachment 109350 [details]

Looks good to me.
Comment 7 Ryosuke Niwa 2011-10-03 16:04:35 PDT
Comment on attachment 109350 [details]

Clearing flags on attachment: 109350

Committed r96553: <http://trac.webkit.org/changeset/96553>
Comment 8 Ryosuke Niwa 2011-10-03 16:04:39 PDT
All reviewed patches have been landed.  Closing bug.