RESOLVED FIXED Bug 68727
Avoid updating compositing state during paint 
https://bugs.webkit.org/show_bug.cgi?id=68727
Summary Avoid updating compositing state during paint
James Robinson
Reported 2011-09-23 13:56:47 PDT
Avoid updating compositing state during paint
Attachments
Patch (3.60 KB, patch)
2011-09-23 14:03 PDT, James Robinson 		simon.fraser: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
James Robinson
Comment 1 2011-09-23 14:03:42 PDT
Created attachment 108533 [details] Patch
Simon Fraser (smfr)
Comment 2 2011-09-23 14:07:05 PDT
Comment on attachment 108533 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=108533&action=review Would be great to have a test case. > Source/WebCore/ChangeLog:10 > + fix this exact issue. Based off the ChangeLog entries, I think that this was just a typo. One space after period. > Source/WebCore/rendering/RenderLayerCompositor.cpp:259 > - case CompositingUpdateOnPaitingOrHitTest: > + case CompositingUpdateOnHitTest: I'm not sure we even have to update compositing on hit testing, since that doesn't have anything to do with compositing.
James Robinson
Comment 3 2011-09-23 14:51:05 PDT
Committed r95863: <http://trac.webkit.org/changeset/95863>
James Robinson
Comment 4 2011-09-23 15:19:16 PDT
(In reply to comment #2) > (From update of attachment 108533 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=108533&action=review > > Would be great to have a test case. Filed https://bugs.webkit.org/show_bug.cgi?id=68738 > > Source/WebCore/rendering/RenderLayerCompositor.cpp:259 > > - case CompositingUpdateOnPaitingOrHitTest: > > + case CompositingUpdateOnHitTest: > > I'm not sure we even have to update compositing on hit testing, since that doesn't have anything to do with compositing. Filed https://bugs.webkit.org/show_bug.cgi?id=68738
James Robinson
Comment 5 2011-09-23 15:19:32 PDT
(In reply to comment #4) > > > Source/WebCore/rendering/RenderLayerCompositor.cpp:259 > > > - case CompositingUpdateOnPaitingOrHitTest: > > > + case CompositingUpdateOnHitTest: > > > > I'm not sure we even have to update compositing on hit testing, since that doesn't have anything to do with compositing. > > Filed https://bugs.webkit.org/show_bug.cgi?id=68738 Sorry I meant https://bugs.webkit.org/show_bug.cgi?id=68739
Note You need to log in before you can comment on or make changes to this bug.