Bug 68678 – Run TestWebKitAPI on Chromium buildbots

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[Xianzhu Wang]

Bug 67756 and bug 68206 let TestWebKitAPI work on Chromium. It's good to also have it run on Chromium buildbots.

[Xianzhu Wang]

Created attachment 108447 [details]
patch

[Darin Fisher (:fishd, Google)]

Comment on attachment 108447 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=108447&action=review

> Tools/BuildSlaveSupport/build.webkit.org-config/master.cfg:640
> +            or platform == 'chromium-mac' or platform == 'chromium-win' or platform == 'chromium-linux')

perhaps this should use platform.startswith('chromium-') instead?

[Peter Beverloo]

(In reply to comment #2)
> (From update of attachment 108447 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=108447&action=review
> 
> > Tools/BuildSlaveSupport/build.webkit.org-config/master.cfg:640
> > +            or platform == 'chromium-mac' or platform == 'chromium-win' or platform == 'chromium-linux')
> 
> perhaps this should use platform.startswith('chromium-') instead?

That wouldn't work for the Android bot, as it uses chromium-android as its platform identifier.

Maybe it would be better to add an exception for that bot, given that various other bots have "chromium-cg-mac" as its platform (even though we're switching to Skia).

[Tony Chang]

Comment on attachment 108447 [details]
patch

r-'ing based on review feedback.  I like Peter's suggestion (platform.startswith('chromium-') and platform != 'chromium-android')).

[Xianzhu Wang]

Created attachment 108582 [details]
patch v2 (requires the patch to bug 68680 to be landed first)

The new patch has only one difference from the suggested change: startswith('chromium') instead of startswith('chromium-') to keep consistent with other startwith() s in the file.

Note: this patch needs to be landed after the patch to bug 68680 otherwise it would break chromium-win buildbot.

[WebKit Review Bot]

Comment on attachment 108582 [details]
patch v2 (requires the patch to bug 68680 to be landed first)

Clearing flags on attachment: 108582

Committed r96289: <http://trac.webkit.org/changeset/96289>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.

[Ryosuke Niwa]

TestWebKitAPI has been failing on cr-win bots ever since it was enabled:
http://build.webkit.org/builders/Chromium%20Win%20Release%20%28Tests%29

[Xianzhu Wang]

(In reply to comment #8)
> TestWebKitAPI has been failing on cr-win bots ever since it was enabled:
> http://build.webkit.org/builders/Chromium%20Win%20Release%20%28Tests%29

The log shows:

Running build-api-tests
'Tools\Scripts\build-api-tests' is not recognized as an internal or external command,
operable program or batch file.
Compiling TestWebKitAPI failed!

Why is 'Tools\Scripts\build-api-tests' missing?

[Xianzhu Wang]

bug 69121. I think I've found where the problem is.