Bug 68678 - Run TestWebKitAPI on Chromium buildbots
Summary: Run TestWebKitAPI on Chromium buildbots
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on: 68680
Blocks:
  Show dependency treegraph
 
Reported: 2011-09-22 21:47 PDT by Xianzhu Wang
Modified: 2011-09-29 19:24 PDT (History)
7 users (show)

See Also:


Attachments
patch (1.66 KB, patch)
2011-09-23 00:27 PDT, Xianzhu Wang
tony: review-
tony: commit-queue-
Details | Formatted Diff | Diff
patch v2 (requires the patch to bug 68680 to be landed first) (1.64 KB, patch)
2011-09-24 04:01 PDT, Xianzhu Wang
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Xianzhu Wang 2011-09-22 21:47:02 PDT
Bug 67756 and bug 68206 let TestWebKitAPI work on Chromium. It's good to also have it run on Chromium buildbots.
Comment 1 Xianzhu Wang 2011-09-23 00:27:16 PDT
Created attachment 108447 [details]
patch
Comment 2 Darin Fisher (:fishd, Google) 2011-09-23 09:50:50 PDT
Comment on attachment 108447 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=108447&action=review

> Tools/BuildSlaveSupport/build.webkit.org-config/master.cfg:640
> +            or platform == 'chromium-mac' or platform == 'chromium-win' or platform == 'chromium-linux')

perhaps this should use platform.startswith('chromium-') instead?
Comment 3 Peter Beverloo 2011-09-23 09:54:26 PDT
(In reply to comment #2)
> (From update of attachment 108447 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=108447&action=review
> 
> > Tools/BuildSlaveSupport/build.webkit.org-config/master.cfg:640
> > +            or platform == 'chromium-mac' or platform == 'chromium-win' or platform == 'chromium-linux')
> 
> perhaps this should use platform.startswith('chromium-') instead?

That wouldn't work for the Android bot, as it uses chromium-android as its platform identifier.

Maybe it would be better to add an exception for that bot, given that various other bots have "chromium-cg-mac" as its platform (even though we're switching to Skia).
Comment 4 Tony Chang 2011-09-23 10:33:19 PDT
Comment on attachment 108447 [details]
patch

r-'ing based on review feedback.  I like Peter's suggestion (platform.startswith('chromium-') and platform != 'chromium-android')).
Comment 5 Xianzhu Wang 2011-09-24 04:01:46 PDT
Created attachment 108582 [details]
patch v2 (requires the patch to bug 68680 to be landed first)

The new patch has only one difference from the suggested change: startswith('chromium') instead of startswith('chromium-') to keep consistent with other startwith() s in the file.

Note: this patch needs to be landed after the patch to bug 68680 otherwise it would break chromium-win buildbot.
Comment 6 WebKit Review Bot 2011-09-28 19:36:39 PDT
Comment on attachment 108582 [details]
patch v2 (requires the patch to bug 68680 to be landed first)

Clearing flags on attachment: 108582

Committed r96289: <http://trac.webkit.org/changeset/96289>
Comment 7 WebKit Review Bot 2011-09-28 19:36:44 PDT
All reviewed patches have been landed.  Closing bug.
Comment 8 Ryosuke Niwa 2011-09-29 11:04:19 PDT
TestWebKitAPI has been failing on cr-win bots ever since it was enabled:
http://build.webkit.org/builders/Chromium%20Win%20Release%20%28Tests%29
Comment 9 Xianzhu Wang 2011-09-29 18:54:35 PDT
(In reply to comment #8)
> TestWebKitAPI has been failing on cr-win bots ever since it was enabled:
> http://build.webkit.org/builders/Chromium%20Win%20Release%20%28Tests%29

The log shows:

Running build-api-tests
'Tools\Scripts\build-api-tests' is not recognized as an internal or external command,
operable program or batch file.
Compiling TestWebKitAPI failed!

Why is 'Tools\Scripts\build-api-tests' missing?
Comment 10 Xianzhu Wang 2011-09-29 19:24:50 PDT
bug 69121. I think I've found where the problem is.